Falling command blocking not working

DarkObscurity commented 4 years ago

Description

Describe the bug

I've set the bskyblock config option PREVENT_TELEPORT_WHEN_FALLING: to true and entered a list of blocked commands as can be seen below. However, when someone jumps of the island he is still able to use /spawn for some reason?

falling-banned-commands:

warp
spawn
cmi spawn
back
cmi back
tpa
cmi tpa
dback
cmi dback
Steps to reproduce the behavior

Setting the config option PREVENT_TELEPORT_WHEN_FALLING: to true and add - spawn to the list of commands mentioned under the option falling-banned-commands:.

Then go to your island and jump of and type /spawn.

Expected behavior

Players should be denied from using the listed commands.

Screenshots and videos (Optional)

Environment

BentoBox Version (Mandatory)

Running PAPER Invalid.
BentoBox version: 1.9.2
Database: MYSQL
Loaded Game Worlds:
bskyblock_world (BSkyBlock): Overworld, Nether, End
Loaded Addons:
Biomes 1.6.0.1 (ENABLED)
BSkyBlock 1.9.0 (ENABLED)
Challenges 0.8.0 (ENABLED)
ControlPanel 1.7.0 (ENABLED)
DimensionalTrees 1.6.0 (ENABLED)
Level 1.9.0 (ENABLED)
Limits 1.9.0 (ENABLED)
TwerkingForTrees 1.1.2 (ENABLED)
Warps 1.9.0 (ENABLED)

Plugins (Optional)

_______

Additional context (Optional)

Paper spigot version: Paper Spigot 1.15.1 Build: git-Paper-31

tastybento commented 4 years ago

What plugin(s) are you using to support the /spawn command? Quote the version numbers so we can check.

DarkObscurity commented 4 years ago

CMI is handling all those commands. Spigot link: https://www.spigotmc.org/resources/cmi-270-commands-insane-kits-portals-essentials-economy-mysql-sqlite-much-more.3742/

We're using the latest version: 8.6.16.5

tastybento commented 4 years ago

So, is it the case that some commands are blocked, but just /spawn isn't? Or are all commands not blocked?

Things to try:

Add a command to the list for another plugin or the native code and confirm it is blocked.
If no commands are blocked, check that player does not have the bskyblock.mod.bypassprotect permission.
Try this version (attached) of BentoBox. I changed the priority of the listener to try and catch the command first.

BentoBox-1.11.0-SNAPSHOT-LOCAL.jar.zip

DarkObscurity commented 4 years ago

Ehh well /is is blocked but /home and /warp isn't blocked either. I'll try the version you provided!

DarkObscurity commented 4 years ago

With this version it seems to be fixed!

Thank you!

tastybento commented 4 years ago

Okay, that's cool. I'll make the change to mainline then.

BentoBoxWorld / BentoBox