search

BentoBoxWorld / BentoBox

Expandable Minecraft server plugin for island-type games like SkyBlock or AcidIsland.
https://bentobox.world
Eclipse Public License 2.0
334 stars 136 forks source link

Default Biome per dimension #1414

Open BONNe opened 4 years ago

BONNe commented 4 years ago

Description

Is your feature request related to a problem?

In 1.16 we have a lot of new nether biomes. However, it is not possible to define default biome in the nether. Only in the overworld.

Describe the solution you'd like us to implement.

As currently, a biome is no "blueprint" specific, I would suggest implementing an ability to specify default biome in gamemode addon config per each dimension. It should be easy to do, as overworld already has it, and config contains specific sections for the nether and the end. And I think it would be useful to allow to specify not only the nether but also the end biome. In the current version, it is pointless, as there is no difference between them, however, it could be changed in future.

Describe alternatives you've considered.

NO ALTERNATIVE! IT SHOULD BE IN THERE!!!

Additional context

:)

tastybento commented 4 years ago

So, actually, this is not in scope for BentoBox. The default-biome setting is something that I made for BSkyBlock and other game modes have copied. BentoBox does not care about the default biome because it does not handle chunk generation. That is done by the game mode. Even for chunk deletion, it just calls the chunk generator of the game mode and pulls the biome from that.

So, it really is something for the gamemode addons to add. Now, we could add it as part of WorldSettings interface, but like I said, BentoBox never uses this, so there is no point really for it to be there. I suggest you just add what you want to CaveBlock and I'll copy it to the others. ;-)

BONNe commented 4 years ago

Well, I know it... Just creating Git Feature request for each GameMode would be a lot of text duplication. I just added general FR in BentoBox.

Poslovitch commented 4 years ago

Now, we could add it as part of WorldSettings interface, but like I said, BentoBox never uses this, so there is no point really for it to be there.

I think we could do that: this way it ensures all the gamemodes are able to do the same thing, i.e. have dimension-specific biomes.

I'm okay for this to be a BentoBox feature, since it's also going to "ease" the work for existing and future gamemodes.

tastybento commented 4 years ago

Status of enabling on Game Mode Addons

BONNe commented 4 years ago

Well, I implemented it in CaveBlock :) What about SkyGrid?