Unable to sit / armorstand dupe

x1p commented 4 years ago

Description

Describe the bug

When a player wants to sit on a chair (stairs) then the player cannot sit however an armor stand is produced which can be mined What happens:

player right clicks on stair
an armor stand is placed inside the stair, falls through the ground
player tries to sit, but is rejected almost immediately
according to the sit plugin, the player still sits. However, the players can walk around since he was rejected.
after the stair is destroyed, the sit plugin recognizes that the player is no longer sitting.

Steps to reproduce the behavior

make a default test server
make sure that a chair plugin functions
place bentobox on it and restart server
make a default island
place a stair and try to sit

Expected behavior

I would expect that bentobox would not interfer with sitting/mounting/armorstand behavior Normally a player can be mounted on a temporary armor stand which is deleted after the player shifts and demount.

Screenshots and videos (Optional)

2020-09-15_21 37 06

Environment

Output of `/bbox version` (Mandatory)

Running PAPER 1.16.3.
BentoBox version: 1.15.1-SNAPSHOT-b1875
Database: JSON
Loaded Game Worlds:
bskyblock_world (BSkyBlock): Overworld, Nether, The End
Loaded Addons:
Biomes 1.13.0 (ENABLED)
BSkyBlock 1.14.1-SNAPSHOT-b673 (ENABLED)
Challenges 0.8.4-SNAPSHOT-b428 (ENABLED)
Level 2.4.1 (ENABLED)
Limits 1.15.0-SNAPSHOT-b230 (ENABLED)
MagicCobblestoneGenerator 2.2.0-SNAPSHOT-b160 (ENABLED)
Warps 1.10.1-SNAPSHOT-b267 (ENABLED)

Plugins (Optional)

ArmorStandTools, BentoBox, CMI, CMIPaperLib, LuckPerms, mcMMO, PlaceholderAPI, PlugMan, ProtocolLib, Vault, WorldEdit, WorldGuard
Instead of CMI which has a build in sit function, some sort of BetterChair(s) can be used

Additional context (Optional)

Although this doesn't look like a bentobox problem, it certainly is. As soon as bentobox is unloaded, the player is able to sit again. If the player is on a non-bentobox world, the player is able to sit again.

tastybento commented 4 years ago

Remove Limits and tell me if this still occurs.

x1p commented 4 years ago

Confirmed: it works fine without limits.

Edit: I tried 230-233 which all had the issue. However, 234 seems to function properly

tastybento commented 4 years ago

Yep, it's a limits issue. I'll close this. I'm going to see if I can still do async with limits. It might need a config.

BentoBoxWorld / BentoBox