BentoBoxWorld / BentoBox

Expandable Minecraft server plugin for island-type games like SkyBlock or AcidIsland.
https://bentobox.world
Eclipse Public License 2.0
334 stars 136 forks source link

GameMode specific BentoBox options. #1532

Open BONNe opened 4 years ago

BONNe commented 4 years ago

Description

Is your feature request related to a problem?

BentoBox config contains some common options, like delation speed and island space reusing. However, if the server contains multiple gamemodes, admins cannot specify differently for each of them.

Describe the solution you'd like us to implement.

In general, I would like to have "duplication" of these settings in game-modes. They could be hidden by default, but if some server owner specifies, that option in game-mode addon, then it should use it.

Additional context

There were some reports in discord, that server crashes on cave deletion, and by stack trace, it looks like the issue is with time-out on chunk regen. But there is no option to change deletion speed or disable it only in CaveBlock. It can be done only on the whole server.

tastybento commented 4 years ago

I think the root cause of the issues should be found first because slowing down deletion isn't necessarily going to fix it. In the case you quote about island deletion in CaveBlock, I did some studying and I think that the issue is that adjacent chunks are loading synchronously. This happens when blocks are placed on the edge of a chunk. Right now, the chunk being regenerated is loaded async, but adjacent ones are not because their loading is triggered by block setting. So, the change would be to load adjacent chunks async as well as the central one and then regenerate the the central one. I'm still experimenting with this.

Poslovitch commented 3 years ago

Any news on this @tastybento ?

tastybento commented 3 years ago

I couldn't get it to work better doing what I said above. Indeed it got worse. I'm stuck on this one. CaveBlock deletion is massively processor intensive. I'm surprised it even works. I'm open to suggestions here.

BONNe commented 3 years ago

That is why I wanted to disable chunk deletion for caveblock But it cannot be done without removing this ability from other gamemodes on server.