search

BentoBoxWorld / BentoBox

Expandable Minecraft server plugin for island-type games like SkyBlock or AcidIsland.
https://bentobox.world
Eclipse Public License 2.0
336 stars 140 forks source link

Error trying to create an island #1669

Closed Barevoss closed 3 years ago

Barevoss commented 3 years ago

Description

Hello again. we are getting an error when we try to create islands. we had it working fine with 5 skyblocks server running, we let it set overnight and restarted the server and got a Null error.

Describe the bug

When a player tries to create an island in any of the skyblock server (names are: bskyblock, Dwarf, Elf, Human, Orc) they get the message "An internal error occurred while attempting to perform this command" output to their screen and the below error in the console.

Steps to reproduce the behavior

Expected behavior

Expected behavior is that the island is created and player is teleported to island and the server not hitting 0 TPS and crashing.

Screenshots and videos (Optional)

the error from the log:

31.01 20:03:18 [Server] Server thread/ERROR null
31.01 20:03:18 [Server] INFO org.bukkit.command.CommandException: Unhandled exception executing 'orc:is create' in world.bentobox.orc.Orc$1(island)
31.01 20:03:18 [Server] INFO at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:156) ~[spigot_1.16.3.jar:git-Spigot-57bbdd8-dea4138]
31.01 20:03:18 [Server] INFO at org.bukkit.craftbukkit.v1_16_R2.CraftServer.dispatchCommand(CraftServer.java:758) ~[spigot_1.16.3.jar:git-Spigot-57bbdd8-dea4138]
31.01 20:03:18 [Server] INFO at org.bukkit.craftbukkit.v1_16_R2.entity.CraftPlayer.performCommand(CraftPlayer.java:360) ~[spigot_1.16.3.jar:git-Spigot-57bbdd8-dea4138]
31.01 20:03:18 [Server] INFO at world.bentobox.bentobox.api.user.User.performCommand(User.java:544) ~[?:?]
31.01 20:03:18 [Server] INFO at world.bentobox.bentobox.api.commands.island.DefaultPlayerCommand.execute(DefaultPlayerCommand.java:127) ~[?:?]
31.01 20:03:18 [Server] INFO at world.bentobox.bentobox.api.commands.CompositeCommand.call(CompositeCommand.java:266) ~[?:?]
31.01 20:03:18 [Server] INFO at world.bentobox.bentobox.api.commands.CompositeCommand.execute(CompositeCommand.java:239) ~[?:?]
31.01 20:03:18 [Server] INFO at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:149) ~[spigot_1.16.3.jar:git-Spigot-57bbdd8-dea4138]
31.01 20:03:18 [Server] INFO at org.bukkit.craftbukkit.v1_16_R2.CraftServer.dispatchCommand(CraftServer.java:758) ~[spigot_1.16.3.jar:git-Spigot-57bbdd8-dea4138]
31.01 20:03:18 [Server] INFO at net.minecraft.server.v1_16_R2.PlayerConnection.handleCommand(PlayerConnection.java:1697) ~[spigot_1.16.3.jar:git-Spigot-57bbdd8-dea4138]
31.01 20:03:18 [Server] INFO at net.minecraft.server.v1_16_R2.PlayerConnection.a(PlayerConnection.java:1540) ~[spigot_1.16.3.jar:git-Spigot-57bbdd8-dea4138]
31.01 20:03:18 [Server] INFO at net.minecraft.server.v1_16_R2.PacketPlayInChat.a(PacketPlayInChat.java:47) ~[spigot_1.16.3.jar:git-Spigot-57bbdd8-dea4138]
31.01 20:03:18 [Server] INFO at net.minecraft.server.v1_16_R2.PacketPlayInChat.a(PacketPlayInChat.java:1) ~[spigot_1.16.3.jar:git-Spigot-57bbdd8-dea4138]
31.01 20:03:18 [Server] INFO at net.minecraft.server.v1_16_R2.PlayerConnectionUtils.lambda$0(PlayerConnectionUtils.java:19) ~[spigot_1.16.3.jar:git-Spigot-57bbdd8-dea4138]
31.01 20:03:18 [Server] INFO at net.minecraft.server.v1_16_R2.TickTask.run(SourceFile:18) ~[spigot_1.16.3.jar:git-Spigot-57bbdd8-dea4138]
31.01 20:03:18 [Server] INFO at net.minecraft.server.v1_16_R2.IAsyncTaskHandler.executeTask(SourceFile:144) ~[spigot_1.16.3.jar:git-Spigot-57bbdd8-dea4138]
31.01 20:03:18 [Server] INFO at net.minecraft.server.v1_16_R2.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23) ~[spigot_1.16.3.jar:git-Spigot-57bbdd8-dea4138]
31.01 20:03:18 [Server] INFO at net.minecraft.server.v1_16_R2.IAsyncTaskHandler.executeNext(SourceFile:118) ~[spigot_1.16.3.jar:git-Spigot-57bbdd8-dea4138]
31.01 20:03:18 [Server] INFO at net.minecraft.server.v1_16_R2.MinecraftServer.ba(MinecraftServer.java:941) ~[spigot_1.16.3.jar:git-Spigot-57bbdd8-dea4138]
31.01 20:03:18 [Server] INFO at net.minecraft.server.v1_16_R2.MinecraftServer.executeNext(MinecraftServer.java:934) ~[spigot_1.16.3.jar:git-Spigot-57bbdd8-dea4138]
31.01 20:03:18 [Server] INFO at net.minecraft.server.v1_16_R2.IAsyncTaskHandler.awaitTasks(SourceFile:127) ~[spigot_1.16.3.jar:git-Spigot-57bbdd8-dea4138]
31.01 20:03:18 [Server] INFO at net.minecraft.server.v1_16_R2.MinecraftServer.sleepForTick(MinecraftServer.java:918) ~[spigot_1.16.3.jar:git-Spigot-57bbdd8-dea4138]
31.01 20:03:18 [Server] INFO at net.minecraft.server.v1_16_R2.MinecraftServer.w(MinecraftServer.java:850) ~[spigot_1.16.3.jar:git-Spigot-57bbdd8-dea4138]
31.01 20:03:18 [Server] INFO at net.minecraft.server.v1_16_R2.MinecraftServer.lambda$0(MinecraftServer.java:164) ~[spigot_1.16.3.jar:git-Spigot-57bbdd8-dea4138]
31.01 20:03:18 [Server] INFO at java.lang.Thread.run(Thread.java:748) [?:1.8.0_262]
31.01 20:03:18 [Server] INFO Caused by: java.lang.NullPointerException

last timings report - https://timings.spigotmc.org/?url=boworinowo

Environment

Output of /bbox version (Mandatory)
31.01 20:17:39 [Server] Server thread/INFO BentoBox version: 1.15.5
31.01 20:17:39 [Server] Server thread/INFO Database: JSON
31.01 20:17:39 [Server] Server thread/INFO Loaded Game Worlds:
31.01 20:17:39 [Server] Server thread/INFO bskyblock_world (BSkyBlock): Overworld, Nether, The End
31.01 20:17:39 [Server] Server thread/INFO dwarf_world (Dwarf): Overworld, Nether, The End
31.01 20:17:39 [Server] Server thread/INFO elf_world (Elf): Overworld, Nether, The End
31.01 20:17:39 [Server] Server thread/INFO human_world (Human): Overworld, Nether, The End
31.01 20:17:39 [Server] Server thread/INFO orc_world (Orc): Overworld, Nether, The End
31.01 20:17:39 [Server] Server thread/INFO Loaded Addons:
31.01 20:17:39 [Server] Server thread/INFO Bank 1.1.1 (ENABLED)
31.01 20:17:39 [Server] Server thread/INFO Biomes 1.13.0 (ENABLED)
31.01 20:17:39 [Server] Server thread/INFO BSkyBlock 1.14.3 (ENABLED)
31.01 20:17:39 [Server] Server thread/INFO Challenges 0.8.3 (ENABLED)
31.01 20:17:39 [Server] Server thread/INFO Chat 1.1.1 (ENABLED)
31.01 20:17:39 [Server] Server thread/INFO CheckMeOut 1.0.2 (ENABLED)
31.01 20:17:39 [Server] Server thread/INFO ControlPanel 1.7.0 (ENABLED)
31.01 20:17:39 [Server] Server thread/INFO DimensionalTrees 1.6.0 (ENABLED)
31.01 20:17:39 [Server] Server thread/INFO Dwarf 1.14.3-SNAPSHOT-LOCAL (ENABLED)
31.01 20:17:39 [Server] Server thread/INFO Elf 1.14.3-SNAPSHOT-LOCAL (ENABLED)
31.01 20:17:39 [Server] Server thread/INFO ExtraMobs 1.11.0.3 (ENABLED)
31.01 20:17:39 [Server] Server thread/INFO Greenhouses 1.4.1 (ENABLED)
31.01 20:17:39 [Server] Server thread/INFO Human 1.14.3-SNAPSHOT-LOCAL (ENABLED)
31.01 20:17:39 [Server] Server thread/INFO Level 2.5.0 (ENABLED)
31.01 20:17:39 [Server] Server thread/INFO Limits 1.15.0 (ENABLED)
31.01 20:17:39 [Server] Server thread/INFO MagicCobblestoneGenerator 2.1.0 (ENABLED)
31.01 20:17:39 [Server] Server thread/INFO Orc 1.14.3-SNAPSHOT-LOCAL (ENABLED)
31.01 20:17:39 [Server] Server thread/INFO TwerkingForTrees 1.4.1 (ENABLED)
31.01 20:17:39 [Server] Server thread/INFO Warps 1.10.0 (ENABLED)

Plugins (Optional)

31.01 20:18:32 [Server] Server thread/INFO Plugins (33): LuckPerms, OpenInv, PlayingWithTime, PortableCraftingInvs, PlaceholderAPI, ChatMonitor, NametagEdit, Playtimes, NoCraftPlus, ChunkHoppers, Vault, WorldEdit, Essentials, SpigotLib, OnlyProxy, ProtocolLib, AuctionHouse, BentoBox, EssentialsChat, TimeIsMoney, EssentialsSpawn, CoreProtect, EnjinMinecraftPlugin, TitleManager, HolographicDisplays, LiteBans, Multiverse-Core, SimplePortals, UltimateStacker, WorldGuard, NexEngine, SilkSpawners, GoldenCrates

Additional context (Optional)

Poslovitch commented 3 years ago

Please provide the content of this file: world.bentobox.orc.Orc. I'd like to have a look at why it passes a null somewhere.

Barevoss commented 3 years ago

any idea where I would find it? still looking but don't know where it would be

Barevoss commented 3 years ago

could it be the .jar file? what do you need me to get to you, it doesn't look like I can paste the file here.

Barevoss commented 3 years ago

o.k. I got the file you are looking for, I think. BSkyBlock-Orc-rename-1.14.3.zip let me know if you need anything else

Barevoss commented 3 years ago 

01.02 18:41:29 [Server] Server thread/WARN "BentoBox v1.15.5" has registered a listener for world.bentobox.bentobox.api.events.island.IslandEvent$IslandDeleteEvent on method "public void world.bentobox.greenhouses.listeners.IslandChangeEvents.onIslandDeleteEvent(world.bentobox.bentobox.api.events.island.IslandEvent$IslandDeleteEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [tastybento, Poslovitch].
Barevoss commented 3 years ago 

01.02 23:24:53 [Server] pool-128-thread-1/INFO ============== SpigotLib Crash Reporter ==============
01.02 23:24:53 [Server] pool-128-thread-1/INFO Your server has been detected having 0 TPS 4 times a row, which means that with high probability it crashed / frozen down. This crash report will help for your developers to detect what's causing the crash. This is NOT an error in SpigotLib, but it's one of it's features, so only contact gyuriX for fixing the error caused this crash if you can pay for it.
01.02 23:24:53 [Server] pool-128-thread-1/INFO =====@ THREAD Async Chat Thread - #1(state=TIMED_WAITING, priority=5) @=====
01.02 23:24:53 [Server] pool-128-thread-1/INFO #1: LINE -2 in FILE Unsafe.java (sun.misc.Unsafe.park)
01.02 23:24:53 [Server] pool-128-thread-1/INFO #2: LINE 215 in FILE LockSupport.java (java.util.concurrent.locks.LockSupport.parkNanos)
01.02 23:24:53 [Server] pool-128-thread-1/INFO #3: LINE 460 in FILE SynchronousQueue.java (java.util.concurrent.SynchronousQueue$TransferStack.awaitFulfill)
01.02 23:24:53 [Server] pool-128-thread-1/INFO #4: LINE 362 in FILE SynchronousQueue.java (java.util.concurrent.SynchronousQueue$TransferStack.transfer)
01.02 23:24:53 [Server] pool-128-thread-1/INFO #5: LINE 941 in FILE SynchronousQueue.java (java.util.concurrent.SynchronousQueue.poll)
01.02 23:24:53 [Server] pool-128-thread-1/INFO #6: LINE 1073 in FILE ThreadPoolExecutor.java (java.util.concurrent.ThreadPoolExecutor.getTask)
01.02 23:24:53 [Server] pool-128-thread-1/INFO #7: LINE 1134 in FILE ThreadPoolExecutor.java (java.util.concurrent.ThreadPoolExecutor.runWorker)
01.02 23:24:53 [Server] pool-128-thread-1/INFO #8: LINE 624 in FILE ThreadPoolExecutor.java (java.util.concurrent.ThreadPoolExecutor$Worker.run)
01.02 23:24:53 [Server] pool-128-thread-1/INFO #9: LINE 748 in FILE Thread.java (java.lang.Thread.run)
01.02 23:24:53 [Server] pool-128-thread-1/INFO =====@ THREAD Attach Listener(state=RUNNABLE, priority=9) @=====
01.02 23:24:53 [Server] pool-128-thread-1/INFO =====@ THREAD Craft Scheduler Thread - 382(state=TIMED_WAITING, priority=5) @=====
01.02 23:24:53 [Server] pool-128-thread-1/INFO #1: LINE -2 in FILE Unsafe.java (sun.misc.Unsafe.park)
01.02 23:24:53 [Server] pool-128-thread-1/INFO #2: LINE 215 in FILE LockSupport.java (java.util.concurrent.locks.LockSupport.parkNanos)
01.02 23:24:53 [Server] pool-128-thread-1/INFO #3: LINE 460 in FILE SynchronousQueue.java (java.util.concurrent.SynchronousQueue$TransferStack.awaitFulfill)
01.02 23:24:53 [Server] pool-128-thread-1/INFO #4: LINE 362 in FILE SynchronousQueue.java (java.util.concurrent.SynchronousQueue$TransferStack.transfer)
01.02 23:24:53 [Server] pool-128-thread-1/INFO #5: LINE 941 in FILE SynchronousQueue.java (java.util.concurrent.SynchronousQueue.poll)
01.02 23:24:53 [Server] pool-128-thread-1/INFO #6: LINE 1073 in FILE ThreadPoolExecutor.java (java.util.concurrent.ThreadPoolExecutor.getTask)
01.02 23:24:53 [Server] pool-128-thread-1/INFO #7: LINE 1134 in FILE ThreadPoolExecutor.java (java.util.concurrent.ThreadPoolExecutor.runWorker)
tastybento commented 3 years ago 
01.02 18:41:29 [Server] Server thread/WARN "BentoBox v1.15.5" has registered a listener for world.bentobox.bentobox.api.events.island.IslandEvent$IslandDeleteEvent on method "public void world.bentobox.greenhouses.listeners.IslandChangeEvents.onIslandDeleteEvent(world.bentobox.bentobox.api.events.island.IslandEvent$IslandDeleteEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [tastybento, Poslovitch].

This is nothing important. Just update to the latest Greenhouses and it'll go away.

tastybento commented 3 years ago 
01.02 23:24:53 [Server] pool-128-thread-1/INFO ============== SpigotLib Crash Reporter ==============
01.02 23:24:53 [Server] pool-128-thread-1/INFO Your server has been detected having 0 TPS 4 times a row, which means that with high probability it crashed / frozen down. This crash report will help for your developers to detect what's causing the crash. This is NOT an error in SpigotLib, but it's one of it's features, so only contact gyuriX for fixing the error caused this crash if you can pay for it.
01.02 23:24:53 [Server] pool-128-thread-1/INFO =====@ THREAD Async Chat Thread - #1(state=TIMED_WAITING, priority=5) @=====
01.02 23:24:53 [Server] pool-128-thread-1/INFO #1: LINE -2 in FILE Unsafe.java (sun.misc.Unsafe.park)
01.02 23:24:53 [Server] pool-128-thread-1/INFO #2: LINE 215 in FILE LockSupport.java (java.util.concurrent.locks.LockSupport.parkNanos)
01.02 23:24:53 [Server] pool-128-thread-1/INFO #3: LINE 460 in FILE SynchronousQueue.java (java.util.concurrent.SynchronousQueue$TransferStack.awaitFulfill)
01.02 23:24:53 [Server] pool-128-thread-1/INFO #4: LINE 362 in FILE SynchronousQueue.java (java.util.concurrent.SynchronousQueue$TransferStack.transfer)
01.02 23:24:53 [Server] pool-128-thread-1/INFO #5: LINE 941 in FILE SynchronousQueue.java (java.util.concurrent.SynchronousQueue.poll)
01.02 23:24:53 [Server] pool-128-thread-1/INFO #6: LINE 1073 in FILE ThreadPoolExecutor.java (java.util.concurrent.ThreadPoolExecutor.getTask)
01.02 23:24:53 [Server] pool-128-thread-1/INFO #7: LINE 1134 in FILE ThreadPoolExecutor.java (java.util.concurrent.ThreadPoolExecutor.runWorker)
01.02 23:24:53 [Server] pool-128-thread-1/INFO #8: LINE 624 in FILE ThreadPoolExecutor.java (java.util.concurrent.ThreadPoolExecutor$Worker.run)
01.02 23:24:53 [Server] pool-128-thread-1/INFO #9: LINE 748 in FILE Thread.java (java.lang.Thread.run)
01.02 23:24:53 [Server] pool-128-thread-1/INFO =====@ THREAD Attach Listener(state=RUNNABLE, priority=9) @=====
01.02 23:24:53 [Server] pool-128-thread-1/INFO =====@ THREAD Craft Scheduler Thread - 382(state=TIMED_WAITING, priority=5) @=====
01.02 23:24:53 [Server] pool-128-thread-1/INFO #1: LINE -2 in FILE Unsafe.java (sun.misc.Unsafe.park)
01.02 23:24:53 [Server] pool-128-thread-1/INFO #2: LINE 215 in FILE LockSupport.java (java.util.concurrent.locks.LockSupport.parkNanos)
01.02 23:24:53 [Server] pool-128-thread-1/INFO #3: LINE 460 in FILE SynchronousQueue.java (java.util.concurrent.SynchronousQueue$TransferStack.awaitFulfill)
01.02 23:24:53 [Server] pool-128-thread-1/INFO #4: LINE 362 in FILE SynchronousQueue.java (java.util.concurrent.SynchronousQueue$TransferStack.transfer)
01.02 23:24:53 [Server] pool-128-thread-1/INFO #5: LINE 941 in FILE SynchronousQueue.java (java.util.concurrent.SynchronousQueue.poll)
01.02 23:24:53 [Server] pool-128-thread-1/INFO #6: LINE 1073 in FILE ThreadPoolExecutor.java (java.util.concurrent.ThreadPoolExecutor.getTask)
01.02 23:24:53 [Server] pool-128-thread-1/INFO #7: LINE 1134 in FILE ThreadPoolExecutor.java (java.util.concurrent.ThreadPoolExecutor.runWorker)

Unfortunately, that stack trace has no useful information in it. If there is any more to that, then paste it all.

Barevoss commented 3 years ago

It appears that a couple user profiles got corrupted, I deleted those user profiles and now they seem to be working good, we get a small about of lag when an island is created, but I kinda expect that. We are going to have about 10 people test it on Feb 3rd. If we have any errors or crashes I will post here. But so far we have 5 skyblock servers running in 1 bentobox..

Barevoss commented 3 years ago

For some reason, whenever we create an island, we get sever lag, TPS drops to zero, and the server crashes. not sure what info you need to help trouble shoot this.

tastybento commented 3 years ago

Full console log and timings report.

Barevoss commented 3 years ago

timings report - https://timings.spigotmc.org/?url=efojoleqih and here is the last crash log and the last 3 log files 2021-02-04-6.log.gz crash-2021-02-04_00.48.40-server.txt latest.log 2021-02-04-5.log.gz

tastybento commented 3 years ago

Are you running vanilla spigot? It looks like the server is crashing due to sync loading of chunks and subsequent lighting calculations that are bringing it to its knees. Things to try:

Barevoss commented 3 years ago

1) we had many issues with paper in the past, biggest issue was linking of portals and we moved away from paper. 2) Is there a way to switch off Level addon or do I need to remove it entirely? 3) we are using the default islands, plus 1 custom island based off the default island. It is no larger than the default. it even has less items in the chest.

tastybento commented 3 years ago
  1. Can you try Paper as an experiment? It would help clarify whether this is a sync chunk loading issue solved by Paper's async capabilities or not.
  2. Yes, go into the Level config and set zero-new-island-levels: false
  3. Okay, so it's not a large blueprint pasting issue.

Try 2 first, if that doesn't help then try 1 and see if that has any effect.

Fredthedoggy commented 3 years ago
  1. Paper has updated their portal linking code so that it matches vanilla: PaperMC/Paper/pull/4781
  2. You could disable it for that gamemode in its config, but tasty was talking about This

Edit: oh tasty beat me to it :P

Barevoss commented 3 years ago

1) disabled Level addon as instructed and restarted server, TPS dropped to 0, kicked player trying to create island. server did not crash this time.

tastybento commented 3 years ago

I feel like I'm missing something here. The game should work fine on Spigot. It shouldn't drop to 0 TPS or kick players. What do you see if you run the gc command in the console?

tastybento commented 3 years ago

Also, are all these worlds SkyBlock? I.e., the world is a void?

Barevoss commented 3 years ago

we switched to Paper and island creation is no longer and issue. Mods are hopping islands and there is zero lag and not dropping TPS. looks like Paper fixed it.

yes, these are all skyblock in void worlds

tastybento commented 3 years ago

Okay. Well, that appears to be the issue for you guys. I'll close this one now then.