BentoBoxWorld / BentoBox

Expandable Minecraft server plugin for island-type games like SkyBlock or AcidIsland.
https://bentobox.world
Eclipse Public License 2.0
329 stars 137 forks source link

Something goes wrong #1881

Closed Jcodeerd closed 2 years ago

Jcodeerd commented 2 years ago

Expected behavior

No / little errors of the plugin

Observed/Actual behavior

console being spammed with

22.11 16:43:50 [Server] INFO java.lang.ClassCastException: class java.lang.String cannot be cast to class java.lang.Boolean (java.lang.String and java.lang.Boolean are in module java.base of loader 'bootstrap')
22.11 16:43:50 [Server] INFO at world.bentobox.bentobox.api.flags.Flag.isSetForWorld(Flag.java:188) ~[BentoBox-1.18.0.jar:?]
22.11 16:43:50 [Server] INFO at world.bentobox.bentobox.listeners.flags.worldsettings.TreesGrowingOutsideRangeListener.onChorusGrow(TreesGrowingOutsideRangeListener.java:40) ~[BentoBox-1.18.0.jar:?]
22.11 16:43:50 [Server] INFO at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor139.execute(Unknown Source) ~[?:?]
22.11 16:43:50 [Server] INFO at org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:69) ~[patched_1.17.1.jar:git-Airplane-98]
22.11 16:43:50 [Server] INFO at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:76) ~[patched_1.17.1.jar:git-Airplane-98]
22.11 16:43:50 [Server] INFO at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[patched_1.17.1.jar:git-Airplane-98]
22.11 16:43:50 [Server] INFO at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:628) ~[patched_1.17.1.jar:git-Airplane-98]
22.11 16:43:50 [Server] INFO at org.bukkit.craftbukkit.v1_17_R1.event.CraftEventFactory.handleBlockSpreadEvent(CraftEventFactory.java:846) ~[patched_1.17.1.jar:git-Airplane-98]
22.11 16:43:50 [Server] INFO at net.minecraft.world.level.block.FireBlock.tick(FireBlock.java:247) ~[app:?]
22.11 16:43:50 [Server] INFO at net.minecraft.world.level.block.state.BlockBehaviour$BlockStateBase.tick(BlockBehaviour.java:917) ~[app:?]
22.11 16:43:50 [Server] INFO at net.minecraft.server.level.ServerLevel.tickBlock(ServerLevel.java:1083) ~[app:?]
22.11 16:43:50 [Server] INFO at com.destroystokyo.paper.server.ticklist.PaperTickList.tick(PaperTickList.java:306) ~[patched_1.17.1.jar:git-Airplane-98]
22.11 16:43:50 [Server] INFO at net.minecraft.server.level.ServerLevel.tick(ServerLevel.java:720) ~[app:?]
22.11 16:43:50 [Server] INFO at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1624) ~[patched_1.17.1.jar:git-Airplane-98]
22.11 16:43:50 [Server] INFO at net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:492) ~[patched_1.17.1.jar:git-Airplane-98]
22.11 16:43:50 [Server] INFO at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1480) ~[patched_1.17.1.jar:git-Airplane-98]
22.11 16:43:50 [Server] INFO at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1279) ~[patched_1.17.1.jar:git-Airplane-98]
22.11 16:43:50 [Server] INFO at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:319) ~[patched_1.17.1.jar:git-Airplane-98]

In the first few minutes after booting, and after that 22.11 16:46:56 [Server] ERROR Could not pass event BlockSpreadEvent to BentoBox v1.18.0

I guess its caused by grass that spreads and errors something, idk

Steps/models to reproduce

See above

BentoBox version

22.11 16:49:16 [Server] INFO Running AIRPLANE 1.17.1. 22.11 16:49:16 [Server] INFO BentoBox version: 1.18.0 22.11 16:49:16 [Server] INFO Database: JSON 22.11 16:49:16 [Server] INFO Loaded Game Worlds: 22.11 16:49:16 [Server] INFO oneblock_world (OneBlock): Overworld, Nether 22.11 16:49:16 [Server] INFO Loaded Addons: 22.11 16:49:16 [Server] INFO AOneBlock 1.9.0-SNAPSHOT-b220 (ENABLED) 22.11 16:49:16 [Server] INFO Border 3.2.0 (ENABLED) 22.11 16:49:16 [Server] INFO Level 2.8.1-SNAPSHOT-b484 (ENABLED) 22.11 16:49:16 [Server] INFO Limits 1.17.2 (ENABLED) 22.11 16:49:16 [Server] INFO Visit 1.4.0 (ENABLED) 22.11 16:49:16 [Server] INFO Warps 1.11.1 (ENABLED)

Plugin list

Plugins (85): AdvancedBan, AntiCurse, AntiDonkeyDupe, AuctionHouse, BanAnnouncer, BentoBox, BetterRTP, BuildersWand, BuycraftX, ChatBrawl, ChatClear, Chunky, Citizens, CleanroomGenerator, ClicksPerSecond, CombatLogX, CommandCooldown, CoreProtect, CrateReloaded, DeluxeAnnounce, DeluxeMenus, DeluxeTags, DiscordSRV, dynmap, EconomyShopGUI-Premium, EliteBosses, EnderVaults, EpicGuard, Essentials, EssentialsChat, EssentialsSpawn, FarmControl, FastAsyncWorldEdit (WorldEdit), floodgate, Geyser-Spigot, GSit, Harbor, HeadDB, HolographicDisplays, IllegalStack, InventoryRollback, Item2Chat, JoinCommands, LibsDisguises, LPC, LuckPerms, Multiverse-Core, MyCommand, NamelessMC, NBTAPI, NexEngine, OpenInv, OtherAntiAFK, PlaceholderAPI, PlugMan, ProInventoryRollBack, ProtocolLib, PyroFishingPro, QuickShop, SafariNet, Scoreboard-revision, Sellwand, SilkSpawners, SirBlobmanCore (SirBlobmanAPI, XSeries), spark, Spicord, StaffChat, STN-Studios-API, SuperVanish, TAB, Tamablefoxes, TempFly, TimeIsMoney, TradeSystem, UltimateAutoRestart, UltimateStacker, Vault, ViaBackwards, ViaRewind, ViaVersion, Votifier, VotingPlugin, WorldBorderAPI, WorldGuard, WorldGuardExtraFlags

Other

If you need the bbox folder, lmk Might still have it from https://github.com/BentoBoxWorld/Level/issues/243

Jcodeerd commented 2 years ago

And now

23.11 21:30:06 [Server] ERROR Could not pass event StructureGrowEvent to BentoBox v1.18.0
23.11 21:30:06 [Server] INFO java.lang.ClassCastException: null

too

BONNe commented 2 years ago

This issue can happen only if someone has set TREES_GROWING_OUTSIDE_RANGE to a number, instead of true or false.

flags list in config.yml must be : . If it is not, GSON will still put a value into the settings map, but the plugin will crash in an unexpected spot.

I am not sure if we should add any protection for wrong input.