BentoBoxWorld / BentoBox

Expandable Minecraft server plugin for island-type games like SkyBlock or AcidIsland.
https://bentobox.world
Eclipse Public License 2.0
334 stars 136 forks source link

Owner can be demoted by sub-owner #2164

Closed Maple-YZ closed 1 year ago

Maple-YZ commented 1 year ago

Expected behavior

The demote command executed by sub-owner for owner should not work.

Observed/Actual behavior

The owner can be demoted by sub-owner using demote command, and would lead to a none-owner island like this: image

Steps/models to reproduce

  1. Player A create a island and invite player B.
  2. Promote player B to sub-owner.
  3. Player A execute command /is settings then click Command Ranks and change the settings to allow sub-owner to use the /island team demote command.
  4. Player B use the /is team demote A to demote A to a sub-owner.

BentoBox version

bbox version 18:05:39 INFO: 服务器: PURPUR 1.20.1 18:05:39 INFO: BentoBox 版本: 1.24.0 18:05:39 INFO: 数据库: JSON

18:05:39 INFO: bskyblock_world (BSkyBlock) : 主世界, 下界, 末地

18:05:39 INFO: Biomes 2.1.1 (ENABLED) 18:05:39 INFO: BSkyBlock 1.16.1 (ENABLED) 18:05:39 INFO: Challenges 1.2.0 (ENABLED) 18:05:39 INFO: Level 2.11.0 (ENABLED) 18:05:39 INFO: Limits 1.19.1 (ENABLED) 18:05:39 INFO: Warps 1.13.0 (ENABLED)

Plugin list

plugins [18:07:38 INFO]: Bukkit Plugins: (47): [18:07:38 INFO]: - AddonPatcher, AdvancedCleaner, AuthMe, BBSToper, BentoBox, BentoBox-Biomes, BentoBox-BSkyBlock, BentoBox-Challenges, BentoBox-Level, BentoBox-Limits [18:07:38 INFO]: BentoBox-Warps, Citizens, CMI, CMILib, CoreProtect, CrazyAuctionsPlus, CrazyCrates, DeluxeMenus, FastAsyncWorldEdit, GSit [18:07:38 INFO]: Images, LiteSignIn, LoginManager, LoneLibs, LuckPerms, Multiverse-Core, PlaceholderAPI, PlugManX, ProtocolLib, PyroFishingPro [18:07:38 INFO]: PyroLib, Shopkeepers, SkBee, Skript, skript-gui, Skript-Packet, skript-placeholders, skript-reflect, skUtilities, spark [18:07:38 INFO]: *SQLibrary, Trivia, Vault, ViaBackwards, ViaVersion, worldedit-selection-viewer, WorldGuard

Other

No response

tastybento commented 1 year ago

Thanks for finding this. This command was not fully developed and you found a good bug!