search

BentoBoxWorld / BentoBox

Expandable Minecraft server plugin for island-type games like SkyBlock or AcidIsland.
https://bentobox.world
Eclipse Public License 2.0
334 stars 138 forks source link

Bentobox Island Reset + Slimefun #2289

Closed rackgaming closed 9 months ago

rackgaming commented 9 months ago

Expected behavior

I expected it to reset the island that I am standing on to be a fresh new one

Observed/Actual behavior

I saw me dangling in the air and instead ended up falling completely until server crash

Steps/models to reproduce

Step to reproduce: install slimefun4 and bentobox and create an island then /is or /sb reset as I did and confirm it then this will happen. 

[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.ConcurrentHashMap$TreeNode.findTreeNode(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.ConcurrentHashMap$TreeNode.findTreeNode(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.ConcurrentHashMap$TreeNode.findTreeNode(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.ConcurrentHashMap$TreeNode.findTreeNode(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.ConcurrentHashMap$TreeNode.findTreeNode(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.ConcurrentHashMap$TreeNode.findTreeNode(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.ConcurrentHashMap$TreeNode.findTreeNode(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.ConcurrentHashMap$TreeNode.findTreeNode(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.ConcurrentHashMap$TreeBin.putTreeVal(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.ConcurrentHashMap$TreeBin.putTreeVal(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.ConcurrentHashMap$TreeBin.putTreeVal(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.ConcurrentHashMap$TreeBin.putTreeVal(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.ConcurrentHashMap.putVal(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.ConcurrentHashMap.putVal(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.ConcurrentHashMap.putVal(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.ConcurrentHashMap.putVal(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.ConcurrentHashMap.put(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.ConcurrentHashMap.put(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.ConcurrentHashMap.put(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.ConcurrentHashMap.put(Unknown Source)
[20:34:40 ERROR]: Slimefun4-RC.jar//io.github.thebusybiscuit.slimefun4.implementation.tasks.TickerTask.queueDelete(TickerTask.java:235)
[20:34:40 ERROR]: Slimefun4-RC.jar//io.github.thebusybiscuit.slimefun4.implementation.tasks.TickerTask.queueDelete(TickerTask.java:235)
[20:34:40 ERROR]: Slimefun4-RC.jar//io.github.thebusybiscuit.slimefun4.implementation.tasks.TickerTask.queueDelete(TickerTask.java:235)
[20:34:40 ERROR]: Slimefun4-RC.jar//io.github.thebusybiscuit.slimefun4.implementation.tasks.TickerTask.queueDelete(TickerTask.java:235)
[20:34:40 ERROR]: Slimefun4-RC.jar//me.mrCookieSlime.Slimefun.api.BlockStorage.clearBlockInfo(BlockStorage.java:611)
[20:34:40 ERROR]: Slimefun4-RC.jar//me.mrCookieSlime.Slimefun.api.BlockStorage.clearBlockInfo(BlockStorage.java:611)
[20:34:40 ERROR]: Slimefun4-RC.jar//me.mrCookieSlime.Slimefun.api.BlockStorage.clearBlockInfo(BlockStorage.java:611)
[20:34:40 ERROR]: Slimefun4-RC.jar//me.mrCookieSlime.Slimefun.api.BlockStorage.clearBlockInfo(BlockStorage.java:611)
[20:34:40 ERROR]: BentoBox-2.0.0-SNAPSHOT-b2546.jar//world.bentobox.bentobox.hooks.SlimefunHook.clearBlockInfo(SlimefunHook.java:31)
[20:34:40 ERROR]: BentoBox-2.0.0-SNAPSHOT-b2546.jar//world.bentobox.bentobox.hooks.SlimefunHook.clearBlockInfo(SlimefunHook.java:31)
[20:34:40 ERROR]: BentoBox-2.0.0-SNAPSHOT-b2546.jar//world.bentobox.bentobox.hooks.SlimefunHook.clearBlockInfo(SlimefunHook.java:31)
[20:34:40 ERROR]: BentoBox-2.0.0-SNAPSHOT-b2546.jar//world.bentobox.bentobox.hooks.SlimefunHook.clearBlockInfo(SlimefunHook.java:31)
[20:34:40 ERROR]: BentoBox-2.0.0-SNAPSHOT-b2546.jar//world.bentobox.bentobox.nms.CopyWorldRegenerator.lambda$copyChunkDataToChunk$17(CopyWorldRegenerator.java:387)
[20:34:40 ERROR]: BentoBox-2.0.0-SNAPSHOT-b2546.jar//world.bentobox.bentobox.nms.CopyWorldRegenerator.lambda$copyChunkDataToChunk$17(CopyWorldRegenerator.java:387)
[20:34:40 ERROR]: BentoBox-2.0.0-SNAPSHOT-b2546.jar//world.bentobox.bentobox.nms.CopyWorldRegenerator.lambda$copyChunkDataToChunk$17(CopyWorldRegenerator.java:387)
[20:34:40 ERROR]: BentoBox-2.0.0-SNAPSHOT-b2546.jar//world.bentobox.bentobox.nms.CopyWorldRegenerator.lambda$copyChunkDataToChunk$17(CopyWorldRegenerator.java:387)
[20:34:40 ERROR]: BentoBox-2.0.0-SNAPSHOT-b2546.jar//world.bentobox.bentobox.nms.CopyWorldRegenerator$$Lambda$16985/0x0000000803400668.accept(Unknown Source)
[20:34:40 ERROR]: BentoBox-2.0.0-SNAPSHOT-b2546.jar//world.bentobox.bentobox.nms.CopyWorldRegenerator$$Lambda$16985/0x0000000803400668.accept(Unknown Source)
[20:34:40 ERROR]: BentoBox-2.0.0-SNAPSHOT-b2546.jar//world.bentobox.bentobox.nms.CopyWorldRegenerator$$Lambda$16985/0x0000000803400668.accept(Unknown Source)
[20:34:40 ERROR]: BentoBox-2.0.0-SNAPSHOT-b2546.jar//world.bentobox.bentobox.nms.CopyWorldRegenerator$$Lambda$16985/0x0000000803400668.accept(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.Optional.ifPresent(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.Optional.ifPresent(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.Optional.ifPresent(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.Optional.ifPresent(Unknown Source)
[20:34:40 ERROR]: BentoBox-2.0.0-SNAPSHOT-b2546.jar//world.bentobox.bentobox.nms.CopyWorldRegenerator.copyChunkDataToChunk(CopyWorldRegenerator.java:387)
[20:34:40 ERROR]: BentoBox-2.0.0-SNAPSHOT-b2546.jar//world.bentobox.bentobox.nms.CopyWorldRegenerator.copyChunkDataToChunk(CopyWorldRegenerator.java:387)
[20:34:40 ERROR]: BentoBox-2.0.0-SNAPSHOT-b2546.jar//world.bentobox.bentobox.nms.CopyWorldRegenerator.copyChunkDataToChunk(CopyWorldRegenerator.java:387)
[20:34:40 ERROR]: BentoBox-2.0.0-SNAPSHOT-b2546.jar//world.bentobox.bentobox.nms.CopyWorldRegenerator.copyChunkDataToChunk(CopyWorldRegenerator.java:387)
[20:34:40 ERROR]: BentoBox-2.0.0-SNAPSHOT-b2546.jar//world.bentobox.bentobox.nms.CopyWorldRegenerator.lambda$regenerateChunk$14(CopyWorldRegenerator.java:357)
[20:34:40 ERROR]: BentoBox-2.0.0-SNAPSHOT-b2546.jar//world.bentobox.bentobox.nms.CopyWorldRegenerator.lambda$regenerateChunk$14(CopyWorldRegenerator.java:357)
[20:34:40 ERROR]: BentoBox-2.0.0-SNAPSHOT-b2546.jar//world.bentobox.bentobox.nms.CopyWorldRegenerator.lambda$regenerateChunk$14(CopyWorldRegenerator.java:357)
[20:34:40 ERROR]: BentoBox-2.0.0-SNAPSHOT-b2546.jar//world.bentobox.bentobox.nms.CopyWorldRegenerator.lambda$regenerateChunk$14(CopyWorldRegenerator.java:357)
[20:34:40 ERROR]: BentoBox-2.0.0-SNAPSHOT-b2546.jar//world.bentobox.bentobox.nms.CopyWorldRegenerator$$Lambda$16984/0x0000000803400000.apply(Unknown Source)
[20:34:40 ERROR]: BentoBox-2.0.0-SNAPSHOT-b2546.jar//world.bentobox.bentobox.nms.CopyWorldRegenerator$$Lambda$16984/0x0000000803400000.apply(Unknown Source)
[20:34:40 ERROR]: BentoBox-2.0.0-SNAPSHOT-b2546.jar//world.bentobox.bentobox.nms.CopyWorldRegenerator$$Lambda$16984/0x0000000803400000.apply(Unknown Source)
[20:34:40 ERROR]: BentoBox-2.0.0-SNAPSHOT-b2546.jar//world.bentobox.bentobox.nms.CopyWorldRegenerator$$Lambda$16984/0x0000000803400000.apply(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.CompletableFuture.uniApplyNow(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.CompletableFuture.uniApplyNow(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.CompletableFuture.uniApplyNow(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.CompletableFuture.uniApplyNow(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.CompletableFuture.uniApplyStage(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.CompletableFuture.uniApplyStage(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.CompletableFuture.uniApplyStage(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.CompletableFuture.uniApplyStage(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.CompletableFuture.thenApply(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.CompletableFuture.thenApply(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.CompletableFuture.thenApply(Unknown Source)
[20:34:40 ERROR]: java.base@19.0.2/java.util.concurrent.CompletableFuture.thenApply(Unknown Source)
[20:34:40 ERROR]: BentoBox-2.0.0-SNAPSHOT-b2546.jar//world.bentobox.bentobox.nms.CopyWorldRegenerator.regenerateChunk(CopyWorldRegenerator.java:350)
[20:34:40 ERROR]: BentoBox-2.0.0-SNAPSHOT-b2546.jar//world.bentobox.bentobox.nms.CopyWorldRegenerator.regenerateChunk(CopyWorldRegenerator.java:350)
[20:34:40 ERROR]: BentoBox-2.0.0-SNAPSHOT-b2546.jar//world.bentobox.bentobox.nms.CopyWorldRegenerator.regenerateChunk(CopyWorldRegenerator.java:350)
[20:34:40 ERROR]: BentoBox-2.0.0-SNAPSHOT-b2546.jar//world.bentobox.bentobox.nms.CopyWorldRegenerator.regenerateChunk(CopyWorldRegenerator.java:350)
Skipped some lines of output
Skipped some lines of output
Skipped some lines of output
Skipped some lines of output`

BentoBox version

![image](https://github.com/BentoBoxWorld/BentoBox/assets/7550358/60e73e6f-31be-44e8-a3a6-ef848332c542) image

Plugin list

image image

Other

No response

rackgaming commented 9 months ago

It also happens on the other game modes too

rackgaming commented 9 months ago

image

tastybento commented 9 months ago

You server cannot handle the extra processing of island deletion with Slimefun. Each block has to be deleted by Slimefun as well as deleted in the world, because otherwise Slimefun blocks can remain and appear when new islands are made and cause mayhem. To fix, try reducing the number of chunks deleted by BentoBox in one go. Edit the BentoBox config file and try maybe 10 instead of 100:

# Island deletion: Number of chunks per world to regenerate per second.
  # If there is a nether and end then 3x this number will be regenerated per second.
  # Smaller values will help reduce noticeable lag but will make deleting take longer.
  # A setting of 0 will leave island blocks (not recommended).
  # Added since 1.7.0.
  delete-speed: 10
rackgaming commented 9 months ago

Am testing now but I think I might have just not updated my SlimeFun to the latest 36 from their page(Don't know where I got mine from but obviously some testing facility that it failed in and was outdated), but after going to their Slimefun 4 RC 36, seems to have no issue creating the island again but yes 10 blocks seem to have made it quicker to re-create the island.

tastybento commented 9 months ago

I just made a change to optimize the deletion. Please try the latest build of BentoBox when it's built on ci.bentobox.world. I tested it, and it seems to be working well with the deletion set at the standard 100 chunks.

rackgaming commented 9 months ago

Yes that's what I did, I am using your latest Bentobox 2.0 and that seemed to fixed the deletion of 100 blocks to work correctly.

rackgaming commented 9 months ago

But will also download the new development one you just posted to make sure nothing wrong happens.