BentoBoxWorld / BentoBox

Expandable Minecraft server plugin for island-type games like SkyBlock or AcidIsland.
https://bentobox.world
Eclipse Public License 2.0
335 stars 138 forks source link

Additions to the new multi island system + potential bug #2366

Closed ILikeOrangeJuice closed 5 months ago

ILikeOrangeJuice commented 6 months ago

Is your feature request related to a problem?

Hello, I already asked about my "issues" in the Discord and got told to create suggestions.

[23:01:12 INFO]: Username issued server command: /is warps    <- Works fine
[23:01:15 INFO]: [BentoBox] [Warps] Username called: `island warp DataMouse` <- doesn't

It DOES work when running the command manually tho as in /island warp DataMouse. So even tho it maybe just is a visual output with the ` in the console, I assume this is still related to the warps part rather than the command blocker as it is the only part causing issues and that for 5+ server running the command blocker with each having 60+ plugins. And I even tested another one too and it behaved the same way for us unfortunately.

Describe the solution you'd like.

1 + 2 to be implemented so it works like the rest. 3 looking into the code what could cause this and eventually fix it if it is related to your side.

Describe alternatives you've considered.

1 + 2 stated in the issue itself. 3 Used 2 different ones, the one we use everywhere and a random up to date one, both seemed to behave the same way.

Agreements

Other

Thanks for looking into this, I appreciate your time and efforts!

tastybento commented 6 months ago

For 1 - see https://github.com/BentoBoxWorld/BentoBox/issues/2344

tastybento commented 6 months ago

I'm working on the tp command right now. It's basically the same code that'll need to be implemented for delete too, which is to specify which island should be deleted.

For the warps thing - what blocker do you use? This could be more on them than Warps. The command is executed using the performCommand Bukkit API, so it may be confusing that plugin. If it's open source then I could check the code they use.

ILikeOrangeJuice commented 6 months ago

The one we currently use is a simple skript which fetches values from a .yml list and checks that variable list if the used command contains it, so nothing fancy, doubt that helps tho? I could send the Skript if it helps, but kinda doubt haha

Awesome about the tp and delete part, thanks for the efforts :)

tastybento commented 6 months ago

@ILikeOrangeJuice In regards to the 3rd one, the ''s are just added in the console, here's the code:

            this.addon.log(this.user.getName() + " called: `" + gamemodeCommand + " " + command + " " + ownerName + "`");
            this.user.performCommand(gamemodeCommand + " " + command + " " + ownerName);

So, it's not actually part of the command. When commands are run in code, they don't use the / slash prefix, so maybe your checker should try to ignore that first character.