BentoBoxWorld / BentoBox

Expandable Minecraft server plugin for island-type games like SkyBlock or AcidIsland.
https://bentobox.world
Eclipse Public License 2.0
322 stars 134 forks source link

Wind Charge are not under any protections #2374

Open BONNe opened 1 month ago

BONNe commented 1 month ago

Is your feature request related to a problem?

Minecraft introduced a new item that players can use to target other entities: WIND_CHARGE. BentoBox currently does not have any protection against it.

  1. Wind Charge can be fired by the player's right click, There is no flag to protect the player from being ejected by Wind Charge. If a visitor uses Wind Charge on an AFK player, and the AFK player is at the edge of the island, the player will be ejected into the void.
  2. Wind Charge can trigger buttons, levers, non-iron doors, trapdoors and fence gates to toggle their block state, extinguish lit candles, and swing bells. In addition, you can also trigger redstone signals by passing through Wooden Pressure Plate, Tripwire, and firing Wind charge at the target to trigger redstone signals. In Bentobox, buttons, levers, non-iron doors and trapdoors, fence gates, lit candles, and swing bells cannot be triggered by Wind Charge.Among Wooden Pressure Plate, Tripwire, and Target, only Wooden Pressure Plate can be protected by the PRESSURE_PLATE flag, The other two do not have any flag to protect them. (Maybe add 2 flags for Tripwire and Target? In vanilla they can be triggered not only by Wind charge, but also by projectiles or entities like arrows, snowballs, thrown tridents, etc.)
  3. When the island owner and the visitor are in the same location, the Wind charge attack from Breeze will not only knock the island owner away, but also the visitor.

Describe the solution you'd like.

A new flag (probably protection) that would prevented unwanted usage of WIND_CHARGE

Describe alternatives you've considered.

No alternative :)

Agreements

Other

No response

tastybento commented 5 days ago

I don't think we need to have a special flag for this right now because I played with it and from what I can tell although it does push animals or players around, if it hurt them then there is already protection, e.g., PVP for players or animal protection. Visitors can push mobs around by walking into them now. So, I recommend we table this for now.

tastybento commented 3 days ago

I updated the description from #2422 for this flag and it does seem that it needs a flag due to the affects it can have.