search

BentoBoxWorld / BentoBox

Expandable Minecraft server plugin for island-type games like SkyBlock or AcidIsland.
https://bentobox.world
Eclipse Public License 2.0
323 stars 134 forks source link

Add-on disable does not always get run #2417

Closed tastybento closed 2 weeks ago

tastybento commented 2 weeks ago

Expected behavior

Always run the onDisable() method when shutting down server

Observed/Actual behavior

As shown, the server can disable the Pladdon's before BentoBox has a chance to disable them:

[08:29:07 INFO]: Stopping the server
[08:29:07 INFO]: Stopping server
[08:29:07 INFO]: [BentoBox-Level] Disabling BentoBox-Level v2.14.0-SNAPSHOT-LOCAL
[08:29:07 INFO]: [BentoBox-BSkyBlock] Disabling BentoBox-BSkyBlock v1.18.0-SNAPSHOT-LOCAL
[08:29:07 INFO]: [BentoBox-Warps] Disabling BentoBox-Warps v1.15.0-SNAPSHOT-b362
[08:29:07 INFO]: [BentoBox-Boxed] Disabling BentoBox-Boxed v2.5.0-SNAPSHOT-LOCAL
[08:29:07 INFO]: [Essentials] Disabling Essentials v2.21.0-dev+81-cde7184
[08:29:07 INFO]: [Multiverse-Core] Disabling Multiverse-Core v4.3.12
[08:29:07 INFO]: [BentoBox] Disabling BentoBox v2.4.0-SNAPSHOT-LOCAL
[08:29:07 INFO]: [BentoBox] Disabling addons...
[08:29:07 INFO]: [BentoBox] Disabling Border...
[08:29:07 INFO]: [BentoBox] Disabling InvSwitcher...
[08:29:07 INFO]: [BentoBox] Addons successfully disabled.
[08:29:07 INFO]: [BentoBox] Removing coops from islands...
[08:29:07 INFO]: [BentoBox] Saving islands - this has to be done sync so it may take a while with a lot of islands...
[08:29:07 INFO]: [BentoBox] Islands saved.
[08:29:07 INFO]: [BentoBox] Closing database.

Steps/models to reproduce

Put something into onDisable for an addon that runs as a Plugin and then stop the server.

BentoBox version

[08:36:32 INFO]: Running PAPER 1.21.
[08:36:32 INFO]: (1.21-40-b45d9b6 (MC: 1.21))
[08:36:32 INFO]: BentoBox version: 2.4.0-SNAPSHOT-LOCAL
[08:36:32 INFO]: Database: JSON
[08:36:32 INFO]: Loaded Game Worlds:
[08:36:32 INFO]: boxed_world (Boxed): Overworld, Nether
[08:36:32 INFO]: bskyblock_world (BSkyBlock): Overworld, Nether, The End
[08:36:32 INFO]: Loaded Addons:
[08:36:32 INFO]: Border 4.3.0 (ENABLED)
[08:36:32 INFO]: Boxed 2.5.0-SNAPSHOT-LOCAL (ENABLED)
[08:36:32 INFO]: BSkyBlock 1.18.0-SNAPSHOT-LOCAL (ENABLED)
[08:36:32 INFO]: InvSwitcher 1.12.0 (ENABLED)
[08:36:32 INFO]: Level 2.14.0-SNAPSHOT-LOCAL (ENABLED)
[08:36:32 INFO]: Warps 1.15.0-SNAPSHOT-b362 (ENABLED)

Plugin list

No response

Other

No response

tastybento commented 2 weeks ago

Fix did not work

tastybento commented 2 weeks ago

Requires Pladdons to return the original instance not always generate a new instance. Pladdons will need fixing.

tastybento commented 2 weeks ago

ToDo: