search

BentoBoxWorld / BentoBox

Expandable Minecraft server plugin for island-type games like SkyBlock or AcidIsland.
https://bentobox.world
Eclipse Public License 2.0
335 stars 140 forks source link

/Is command not working properly #2524

Closed B1ackEx closed 1 month ago

B1ackEx commented 1 month ago

Expected behavior

The issue I'm facing is that players have to type /is multiple times, even though they are standing on their island.

Observed/Actual behavior

The issue I'm facing is that players have to type /is multiple times, even though they are standing on their island."

Steps/models to reproduce

image_2024-10-01_082438432 image

BentoBox version

11:22:07 INFO: Running PAPER 1.20.1.

11:22:07 INFO: BentoBox version: 2.5.0 11:22:07 INFO: Database: JSON 11:22:07 INFO: Loaded Game Worlds: 11:22:07 INFO: skyblock (Skyblock): Overworld 11:22:07 INFO: Loaded Addons: 11:22:07 INFO: Biomes 2.1.1 (ENABLED) 11:22:07 INFO: Border 4.2.2 (ENABLED) 11:22:07 INFO: BSkyBlock 1.18.0 (ENABLED) 11:22:07 INFO: Challenges 1.3.1 (ENABLED) 11:22:07 INFO: Level 2.15.0 (ENABLED) 11:22:07 INFO: Likes 2.4.0 (ENABLED) 11:22:07 INFO: MagicCobblestoneGenerator 2.5.1 (ENABLED) 11:22:07 INFO: Upgrades 0.3.0-SNAPSHOT-b136 (ENABLED) 11:22:07 INFO: Warps 1.14.0 (ENABLED)

Plugin list

[11:22:31 INFO]: - WolfyUtilities [11:22:31 INFO]: Bukkit Plugins: (83): [11:22:31 INFO]: - AdvancedAntiVPN, AdvancedEnchantments, AuthMe, BankPlus, BentoBox, BentoBox-Biomes, BentoBox-BSkyBlock, BentoBox-Challenges, BentoBox-Level, BentoBox-Likes [11:22:31 INFO]: BentoBox-MagicCobblestoneGenerator, BentoBox-Warps, BotSentry, *CarbonsAnnouncer, ChatControl, ChatGames-Premium, ChunkSpawnerLimiter, Citizens, CMI, CMIEInjector [11:22:31 INFO]: CMILib, CoreProtect, CraftingStore, CrazyCrates, CustomDrops, DeluxeMenus, DeluxeTags, DiscordSRV, DiscordSRVUtils, Elevator [11:22:31 INFO]: EpicPluginLib, EvenMoreFish, ExecutableItems, ExpensiveDeaths, FastAsyncWorldEdit, HeadDatabase, IllegalStack, Images, InteractiveChat, InteractiveChatDiscordSrvAddon [11:22:31 INFO]: LibsDisguises, LiteBans, LuckPerms, Multiverse-Core, MythicMobs, NBTAPI, NoPlugins, PlaceholderAPI, PlayerPoints, PlayerVaults [11:22:31 INFO]: PlayMoreSounds, ProtocolLib, Quests, RealisticSeasons, SCore, ShopGUIPlus, ShopGUIPlus-SellGUI, Shopkeepers, SkinsRestorer, spark [11:22:31 INFO]: StaffPlusPlus, StaffPlusPlusDiscord, StoreStats, TAB, TabCompleteFilter, TeaksTweaks, theBartender, TradeSystem, Ultimate_BlockRegeneration, UltimateAutoRestart [11:22:31 INFO]: UltraCosmetics, UltraScoreboards, UpgradeableHoppers, Vault, ViaBackwards, ViaVersion, VoidTeleport, Votifier, VotingPlugin, WorldGuard [11:22:31 INFO]: WorldGuardExtraFlags, zAuctionHouseV3, zMenu

Other

No response

tastybento commented 1 month ago

@B1ackEx BentoBox-2.6.0-SNAPSHOT-LOCAL.jar.zip

Please try this version that has debug turned on. When players do /is, then you'll see something like this log (I did this on OneBlock, but it's the same type of output):

[11:19:10 INFO]: BoxManager issued server command: /ob
[11:19:10 INFO]: [BentoBox] DEBUG: BoxManager is going home
[11:19:10 INFO]: [BentoBox] DEBUG: Getting safe home location for BoxManager
[11:19:10 INFO]: [BentoBox] DEBUG: Loading the destination chunk asyc for BoxManager
[11:19:10 INFO]: [BentoBox] DEBUG: Chunk loaded asyc for BoxManager in 0ms
[11:19:10 INFO]: [BentoBox] DEBUG: Checking if the location is safe for BoxManager
[11:19:10 INFO]: [BentoBox] DEBUG: BoxManager: we need to try other locations on the island. Load the island center chunk async...
[11:19:10 INFO]: [BentoBox] DEBUG: Island center chunk loaded for BoxManager in 0ms
[11:19:10 INFO]: [BentoBox] DEBUG: Location is not safe for BoxManager
[11:19:10 INFO]: [BentoBox] DEBUG: Trying all locations up to max height above bedrock for BoxManager
[11:19:10 INFO]: [BentoBox] DEBUG: Nowhere is safe for BoxManager
[11:19:10 INFO]: [BentoBox] DEBUG: Try to fix this teleport location and teleport the player if possible BoxManager
[11:19:10 INFO]: [BentoBox] DEBUG: Home number = 0 Home name = ''
[11:19:10 INFO]: [BentoBox] DEBUG: '' => Location{world=CraftWorld{name=oneblock_world},x=0.5,y=81.0,z=0.5,pitch=0.0,yaw=0.0}

Not all the lines will show, this is just an example.

I'd like to see your logs for when the player is having this issue.

Also, I changed the user feedback already to tell users that teleporting is in progress if they type it multiple times.

As you can see from my log, chunks load immediately (0 milliseconds), but I expect yours may be taking a while. I'd like to see how long.

B1ackEx commented 1 month ago

[11:30:32 INFO]: _BadLife issued server command: /is [11:30:32 INFO]: [BentoBox] DEBUG: _BadLife is going home [11:30:32 INFO]: [BentoBox] DEBUG: Getting safe home location for _BadLife [11:30:32 INFO]: [BentoBox] DEBUG: Loading the destination chunk asyc for _BadLife [11:30:32 INFO]: [BentoBox] DEBUG: Chunk loaded asyc for _BadLife in 4ms [11:30:32 INFO]: [BentoBox] DEBUG: Checking if the location is safe for _BadLife [11:30:32 INFO]: [BentoBox] DEBUG: Teleporting _BadLife async [11:30:32 INFO]: [BentoBox] DEBUG: Location is safe for _BadLife [11:30:32 INFO]: [BentoBox] DEBUG: Failed to teleport _BadLife async! - took 2ms

On Wed, Oct 2, 2024 at 4:10 AM tastybento @.***> wrote:

@B1ackEx https://github.com/B1ackEx BentoBox-2.6.0-SNAPSHOT-LOCAL.jar.zip https://github.com/user-attachments/files/17214271/BentoBox-2.6.0-SNAPSHOT-LOCAL.jar.zip

Please try this version that has debug turned on. When players do /is, then you'll see something like this log (I did this on OneBlock, but it's the same type of output):

[11:19:10 INFO]: BoxManager issued server command: /ob [11:19:10 INFO]: [BentoBox] DEBUG: BoxManager is going home [11:19:10 INFO]: [BentoBox] DEBUG: Getting safe home location for BoxManager [11:19:10 INFO]: [BentoBox] DEBUG: Loading the destination chunk asyc for BoxManager [11:19:10 INFO]: [BentoBox] DEBUG: Chunk loaded asyc for BoxManager in 0ms [11:19:10 INFO]: [BentoBox] DEBUG: Checking if the location is safe for BoxManager [11:19:10 INFO]: [BentoBox] DEBUG: BoxManager: we need to try other locations on the island. Load the island center chunk async... [11:19:10 INFO]: [BentoBox] DEBUG: Island center chunk loaded for BoxManager in 0ms [11:19:10 INFO]: [BentoBox] DEBUG: Location is not safe for BoxManager [11:19:10 INFO]: [BentoBox] DEBUG: Trying all locations up to max height above bedrock for BoxManager [11:19:10 INFO]: [BentoBox] DEBUG: Nowhere is safe for BoxManager [11:19:10 INFO]: [BentoBox] DEBUG: Try to fix this teleport location and teleport the player if possible BoxManager [11:19:10 INFO]: [BentoBox] DEBUG: Home number = 0 Home name = '' [11:19:10 INFO]: [BentoBox] DEBUG: '' => Location{world=CraftWorld{name=oneblock_world},x=0.5,y=81.0,z=0.5,pitch=0.0,yaw=0.0}

Not all the lines will show, this is just an example.

I'd like to see your logs for when the player is having this issue.

Also, I changed the user feedback already to tell users that teleporting is in progress if they type it multiple times.

As you can see from my log, chunks load immediately (0 milliseconds), but I expect yours may be taking a while. I'd like to see how long.

— Reply to this email directly, view it on GitHub https://github.com/BentoBoxWorld/BentoBox/issues/2524#issuecomment-2386679617, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS2X3UGTZDVBQDXX3KOXL2TZZMTVBAVCNFSM6AAAAABPEULSN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBWGY3TSNRRG4 . You are receiving this because you were mentioned.Message ID: @.***>

tastybento commented 1 month ago

Wow. That means that the Paper teleport is failing for some reason. I'll have to ask the Paper folks why. Thanks for the debug.

B1ackEx commented 1 month ago

I am using purpur

On Wed, Oct 2, 2024, 8:49 AM tastybento @.***> wrote:

Wow. That means that the Paper teleport is failing for some reason. I'll have to ask the Paper folks why. Thanks for the debug.

— Reply to this email directly, view it on GitHub https://github.com/BentoBoxWorld/BentoBox/issues/2524#issuecomment-2387572331, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS2X3UATRGVRGCFDREFKAD3ZZNULVAVCNFSM6AAAAABPEULSN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBXGU3TEMZTGE . You are receiving this because you were mentioned.Message ID: @.***>

tastybento commented 1 month ago

Yeah I see that. It may be a bug with 1.20.1 that they fixed. Failing to teleport should never happen. I've looked at CraftBukkit code and the only reason it should fail is if you were a vehicle or removed. Seems to be a bug in the server code. I don't know if they fixed it, but you may want to consider updating to a later server version.

tastybento commented 1 month ago

Yeah, the Paper discord are saying - old version, not supported, and sorry, no support for Purpur.

B1ackEx commented 1 month ago

ugh alright 😓

On Wed, Oct 2, 2024, 9:22 AM tastybento @.***> wrote:

Yeah, the Paper discord are saying - old version, not supported, and sorry, no support for Purpur.

— Reply to this email directly, view it on GitHub https://github.com/BentoBoxWorld/BentoBox/issues/2524#issuecomment-2387598679, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS2X3UEMQDC54ILSULWNE43ZZNYJXAVCNFSM6AAAAABPEULSN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBXGU4TQNRXHE . You are receiving this because you were mentioned.Message ID: @.***>