Hook into Dynmap

[Poslovitch]

Is your feature request related to a problem? Please describe. ASkyBlock had a dynmap addon for it some time ago.

Describe the solution you'd like Provide a hook for Dynmap so that Gamemode addons can provide markers/layout for their world. Here is the API: DynmapCommonAPI.java.

Additional context We may have to provide some wrapper methods, but that'd overall be fine.

[tastybento]

This brings back memories!

[Poslovitch]

I've started to work on this - this is actually kinda easy, I'm impressed.

[Poslovitch]

Just so I don't lose time finding the code again, here's the direct link to ASkyBlock's dynmap hook: https://github.com/tastybento/dynmapASkyblock/blob/master/src/main/java/com/wasteofplastic/dynmap/DynmapASkyBlock.java

[TheWranger]

Would be useful for displaying island warp signs as markers on the map.

[tastybento]

I might need to add that to the warp signs add on.

[Poslovitch]

I'll try to do an "API" in the DynmapHook ;)

[Poslovitch]

Postponing to 1.5.0 as this is not a high priority enhancement request.

[Poslovitch]

Working on that now :)

[Poslovitch]

Okay, so I got it working.

However, I don't know what I should put on it right now :/

[Poslovitch]

Well. I'll be lazy and say that the purpose of this issue has been fulfilled. We'll see over time if people want every gamemode addon to display something by default. But shhhhhh!

[ghost]

What's the actual status of this? I see the BSkyBlock toggle in the DynMap menu but nothing actually displays on the map.

Ownership/Name information about each island would be good.

[tastybento]

@Poslovitch Someone asked!

[Poslovitch]

What's the actual status of this? I see the BSkyBlock toggle in the DynMap menu but nothing actually displays on the map.

Ownership/Name information about each island would be good.

While the Hook is already there, its implementation has not been completed. Sorry for the inconvenience.

[johncsuti]

Any eta when about we can expect this to be completed something like 1.9.1?

[Poslovitch]

It requires a more thoughtful planning than I thought it would. I'll work on this as a side thing, and see when it's ready.

[johncsuti]

Can we hook this into borders as well and display a red border of stained glass to show the island protection range?

[johncsuti]

Dynmap works great for the overworld is there a way to make it work in the end and nether? This is what i get in the nether the end it seems to work kinda but you can't zoom like you can on the overworld.

[johncsuti]

Here is the end islands you can't zoom in more then this.

[fnutt]

Please fix this issue. The lack of Dynmap integration in BentoBox is severe for my server.

Status?

[Poslovitch]

@johncsuti I'm not sure I could do anything about the Nether and End dynmaps. I'm not doing anything related to them in the code, so that might be a dynmap issue (to be confirmed).

@fnutt I have tried locally a few different implementations to finish this feature. None of them were satisfying. I'll retry and try to get this done for 1.11.0.

[johncsuti]

Well the major issue is the nether not showing anything. Is there a way to make the top of the nether see through so you can see the inside? Also to be confirmed as in your asking the author?

[Poslovitch]

I honestly don't know if hiding the nether roof would be possible. And yeah, I meant "to be confirmed" as in I am going to ask the author about it.

[johncsuti]

Okay sounds like to me hiding the nether roof for skyblock would have to be built into dynmap. Not something you can code in unless the author allows you to code in a version of it into the addon.

[tastybento]

Doesn't dynmap have a 3d view? In that case, the roof doesn't show - or does it?

[johncsuti]

3D doesn’t work on the nether it does work in the end with the same result as above. @tastybento you know my server ip you can also jump on my skyblock sever and register then go to dynmap.64stacks.com to login and check it out if you want.

[fnutt]

I suggest disabling map for Nether in Dynmap, @johncsuti. Regarding The End zooming, live with it! This is not an issue for BentoBox to solve.

If you really want hiding x-number of blocks from the top, or let yourself zoom further in on the map, talk to Dynmap plugin author(s).

[johncsuti]

@fnutt considering it works fine with regular nether worlds and considering this is a enhancement it isn’t something bento box needs to fix per say. Obviously this is an enhancement thread to tie bentobox into dynmap if the nether isn’t showing islands correctly this could be a big problem for some server owners. Once again the whole point of this is to make cool addons for bentobox. Not wether or not it needs to be “fixed” by them. Also the end zooming is not something that should be lived with either it works 100% just like the rest of bentobox or don’t bother making it in the first place. Lastly I’m getting the feeling your not understanding this is an enhancement thread and not a bug report. Your last comment would be great if this was a bug report, but it’s not hence why it make no sense.

[fnutt]

Well, can we first get the support for overworld map done? ...before trying to make Dynmap plugin authors make changes to their plugin to let you zoom further and hide nether roof. Please.

Babysteps first, implement features one by one.

[johncsuti]

Support for the overworld is done aside from markers and other enhancements. All the point of my original post is to fix issues/bugs before this gets released. Furthermore it seems that you are missing a major part of the whole conversation above between me and @Poslovitch where he said “to be confirmed” as in he would ask the author of dynmap on what is wrong with the nether and the end. At this point we don’t need baby steps as the first biggest part is completed and we need to finish implementing the markers and fixing things like the nether and the end.

[johncsuti]

Finally I would like to reinforce two points. Point one reread the entire conversation between two people before commenting on it. Second get the latest dev build of bentobox and skyblock and test the issue at hand before you go saying “can we get support for the overworld map done?”.

As you would be able to tell by testing that both your comments so far make no sense, since they are done and now all the features and issues need to be done. I am simply putting my findings on issues and enhancements here since there is no addon repository for this.

[BONNe]

BentoBox currently does not manage anything from Dynamp. Yes, there exist hook, and something is displayed in map, but it is not done at all. The current implementation is just a jump-off point, and it is not configured at all. The implemented thing is just an ability to automatically hook all existing game-modes with DynMap API and create own markers. But no markers or regions are added, or any config from API side is done.

There are API things that can be done from BentoBox side, and it will be done, but there also exist things that should be done by DynMap page (config file on map viewer), and if I remember correctly, the nether roof is one of the things, that must be configured via it. It could be the same with the end.

As BentoBox generates its own worlds, then I assume they are not configured in DynMap config file, so they are worked the same as default overworld, but should be targeted as nether.

[Poslovitch]

As I currently have no means of testing any new features, I am postponing this to a later release.

[johncsuti]

@Poslovitch just let me know if you need help with testing I can also give you access to some of my servers if needed

[Poslovitch]

i am having an issue on my laptop that prevents me from building any local development builds. But since you said it, I'll be very happy to have a few bigger servers to test things on when the Hook finally gets implemented. 🙂

[johncsuti]

Yeah I don't have very many players currently but I do go on often. I also have large amounts of ram dedicated to the network. It is also good to test it on a server that you have not built just to make sure your specific hardware is not causing issues. Well in that case fixing some of the issues.

[Poslovitch]

Back in progress!

[Poslovitch]

I will keep working on it on this branch: https://github.com/BentoBoxWorld/BentoBox/tree/dynmap-hook

[RemyyB]

Hey there, what is the status on this for full release? Thank you in advance :)

[Poslovitch]

Still pending. I'm working on and off on BentoBox-related projects, but not as much on BentoBox itself as before. I'll try to get back to it at some point, but for now I'm willing to explore new grounds (web and Android development).

[RemyyB]

Okay thank you :), good luck with your web/app development!

[ghost]

And. Now? It would be awesome to be able to use it as on ASkyBlock. It is really useful

[Sylensky]

I would really love to see some tooltips with island stats/properties on the dynmap. Hope this will be added in near future :)

[Poslovitch]

@BONNe Reopening, as it seems it's not been completed by said commit.

[BONNe]

Sorry, that was a fix for a report in BSkyBlock repo.