Incorrect sethome location for player on /is team accept

[wellnesscookie]

Description

Describe the bug

• It happens from time-to-time that we receive complains on players not having their home correctly set after using /is team accept. To be more precise, it happens that their home which is set is actually the Location of the place from where they executed /is team accept.

Steps to reproduce the behavior

• I am sorry but we are not able to determine when and how

Expected behavior

Plugins

[06:32:17 INFO]: Plugins (50): AnimatedNames*, AreaShop, ArmorStandTools, BentoBox, BungeeTabListPlus*, ChatControl, ChestCommands, ChestShop*, ClearLag*, CrateReloaded, EditableSign, Essentials, EssentialsChat*, EssentialsSpawn*, ExecuteEverywhere*, FastAsyncWorldEdit*, FeatherBoard*, HeadDatabase*, HolographicDisplays, HungerKeeperPlus*, IPWhitelist*, IslandBorder, LeaderHeads*, LibsDisguises, LuckPerms, MobManager*, Multiverse-Core*, MVdWPlaceholderAPI*, NickRemover*, NoSleepCMDs*, OpenInv*, PlayerHeads, PlayerPoints*, ProtocolLib*, PvPManager*, PvPManagerBossBar*, RedstoneClockDetector*, RPGHealthIndicator*, SilkSpawners, SkinsRestorer, Spartan, TradeMe, TrophyHeads*, UnbreakingAnvils*, Vault*, VoidGenerator, WorldEdit, WorldGuard, WorldGuardPistonFix*, Yamler*

BentoBox setup

BentoBox and Addons

[23:52:33] [main/INFO]: [CHAT] Running PAPER 1.13.2.
[23:52:33] [main/INFO]: [CHAT] BentoBox version: 1.5.0-SNAPSHOT
[23:52:33] [main/INFO]: [CHAT] Loaded Game Worlds:
[23:52:33] [main/INFO]: [CHAT] skyblock (skyblock)
[23:52:33] [main/INFO]: [CHAT] Loaded Add-Ons
[23:52:33] [main/INFO]: [CHAT] Biomes 0.4.5-SNAPSHOT-#28
[23:52:33] [main/INFO]: [CHAT] BSkyBlock 1.5.0
[23:52:33] [main/INFO]: [CHAT] Challenges 0.7.0-SNAPSHOT-#169
[23:52:33] [main/INFO]: [CHAT] Level 1.4.0
[23:52:33] [main/INFO]: [CHAT] Limits 0.2.0-SNAPSHOT
[23:52:33] [main/INFO]: [CHAT] SerbCraftAddon 2.2
[23:52:33] [main/INFO]: [CHAT] WelcomeWarps 1.4.0

Configuration

• Database: mySQL

Additional context

• Will do some investigation myself

[wellnesscookie]

I think I found what's wrong, but let me know if I'm mistaken. https://github.com/BentoBoxWorld/BentoBox/pull/666 EDIT: We were able to reproduce is only when the island was locked, but I don't know if the fix works, I guess it will?

[wellnesscookie]

Steps to reproduce this behavior:

• Have the island owner invite you while the Island is locked for Trusted or less (Coop & Visitors)

• Type /is team accept

• Code execution order will try to: --Teleport you (To the locked island while you are still not added) --Set your home (Takes your current location) --Add you as a member of that island

• Considering the teleportation failed due to you still being a Visitor for Locked Island - taken location is the one from where you executed /is team accept

[Poslovitch]

Thanks for the fix #666 @wellnesscookie !