Portals(nether, end) teleport delay bug

SirvydasS commented 5 years ago

Description

Describe the bug

It was everything good, but when i update bentobox to 1.7 from 1.6 it appears. It was about 5 second delay when you touch portal and after that delay you and you are being teleported no matter where you go during that delay. So i go back to 1.6 version but problem still here, but delay decreased to 1 sec. but is still easy to see because when you go trow end portal you fall in lava and starting burning. I was try newly created server with bentobox and on 1.7 and problem was still here, but delay was about 1-2 sec. Always was using same add ons.

Steps to reproduce the behavior

Have bentobox 1.7 and bskyblock.
Create nether portal in new island and go into. (you start see delay)
Make end portal and jump in to.

Screenshots and videos

https://youtu.be/98uaRptBGdA

Expected behavior

No delay when you going to portals. when you touch portal in the blink of an eye you teleport.

Environment

Server

OS: Linux Debian-91-stretch-64-minimal 4.9.0-3-amd64
Java version: 12

Plugins

ActionButtons, BentoBox, BungeeTabListPlus*, CoreProtect, DeathMessagesPrime, EditableSign, EZRanksLite*, HolographicDisplays, HungerKeeperPlus*, InventoryGUI, KCore, KillerMoney*, Kits, Market, mcMMO, Multiverse-Core, NoCheatPlus, Permissions, ProxyBridge, SkinsRestorer, Trading, Vault, WorldEdit, WorldGuard

BentoBox setup

BentoBox and Addons

[18:16:30 INFO]: Running PAPER 1.14.4.
[18:16:30 INFO]: BentoBox version: 1.6.0
[18:16:30 INFO]: Database: JSON
[18:16:30 INFO]: Loaded Game Worlds:
[18:16:30 INFO]: bskyblock_world (BSkyBlock): Overworld, Nether, End
[18:16:30 INFO]: Loaded Addons:
[18:16:30 INFO]: Biomes 1.6.0.2-SNAPSHOT-b141 (ENABLED)
[18:16:30 INFO]: BSkyBlock 1.6.0 (ENABLED)
[18:16:30 INFO]: Challenges 0.8.0-SNAPSHOT-#329 (ENABLED)
[18:16:30 INFO]: DimensionalTrees 1.6.0 (ENABLED)
[18:16:30 INFO]: Greenhouses 0.4.0-SNAPSHOT (ENABLED)
[18:16:30 INFO]: Level 1.6.0 (ENABLED)
[18:16:30 INFO]: Limits 1.6.0 (ENABLED)
[18:16:30 INFO]: MagicCobblestoneGenerator 1.5.0.1 (ENABLED)
[18:16:30 INFO]: WelcomeWarps 1.6.1 (ENABLED)

Configuration

Database: JSON

Additional context

tastybento commented 5 years ago

The safe spot teleporting search was slowed down in 1.7 because it was causing too much lag for other players. It was set to only check 3 chunks per tick. However, the search radius of 200 blocks was not changed, so this means it could take 10 ~ 20 seconds to search for a nether portal before giving up. This is obviously too long.

[x] Speed up the search and reduce radius

Teleporting to End has been sped up with this change because teleporting to the End is never done to a portal so no portal search has to occur. However, if the teleport location is not safe then searching will be required which may take up to 3 seconds worst case. If a safe spot is found, then it should be possible to remember it for next time and be quick.

[ ] Set new spawn location when safe spot found

SirvydasS commented 5 years ago

Nice, end portal teleport fixed! But i got still a problem with nether teleport is take too much time to teleport. I upload new version on that same server where was been 1.6 and 1.7 in the video I show whats happens https://youtu.be/ogAq_5GUGzQ On new clean server (with the same bluperints as in main server) i have no problems with nether portal 3 seconds and good. Maybe I need delete some old data for the fix?

tastybento commented 5 years ago

You wrote:

On new clean server (with the same bluperints as in main server) i have no problems with nether portal 3 seconds and good.

Just to clarify - are you saying that with a clean server it takes just 3 seconds? That is what I am seeing.

If so, what is the video showing? It looks like there was a cut in the middle. Are you sure you were using the latest build?

tastybento commented 5 years ago

Oops. I hadn't pushed the nether fix so that's why you didn't see it. Ignore my comment above and use the latest build.

BentoBoxWorld / BentoBox