search

BentoBoxWorld / BentoBox

Expandable Minecraft server plugin for island-type games like SkyBlock or AcidIsland.
https://bentobox.world
Eclipse Public License 2.0
329 stars 137 forks source link

Paper forks #992

Closed x1p closed 4 years ago

x1p commented 4 years ago

Description

Describe the bug

Bentobox seems not to recognize forks of Paper as Paper and gives this message at startup

[04:03:01 INFO]: [BentoBox] Enabling BentoBox v1.8.0-SNAPSHOT-b1389
[04:03:01 WARN]: [BentoBox] ************ Disclaimer **************
[04:03:01 WARN]: [BentoBox] BentoBox may not be compatible with this server!
[04:03:01 WARN]: [BentoBox] BentoBox is tested only on the following Spigot versions:
[04:03:01 WARN]: [BentoBox] 1.14.4
[04:03:01 WARN]: [BentoBox] **************************************

Steps to reproduce the behavior

  1. Download Purpur from https://ci.pl3x.net/job/Purpur/
  2. Start server
  3. Compare log to a log from a server running Paper

Screenshots and videos

Expected behavior

Perhaps Bentobox could recognize Purpur as Paper

Environment

Server

Plugins

BentoBox, ChestShop, dynmap*, LuckPerms, mcMMO, PlaceholderAPI*, PlugMan, Vault, WorldBorder, WorldEdit, WorldGuard

BentoBox setup

BentoBox and Addons
Running Invalid 1.14.4.
BentoBox version: 1.8.0-SNAPSHOT-b1389
Database: JSON
Loaded Game Worlds:
bskyblock_world (BSkyBlock): Overworld, Nether, End
Loaded Addons:
Biomes 1.6.0.2-SNAPSHOT-b141 (ENABLED)
BSkyBlock 1.8.0-SNAPSHOT-b457 (ENABLED)
Challenges 0.8.0 (ENABLED)
Level 1.7.0-SNAPSHOT-b284 (ENABLED)
Limits 1.7.0-SNAPSHOT-b167 (ENABLED)
MagicCobblestoneGenerator 1.5.0.1 (ENABLED)
Warps 1.7.0 (ENABLED)
Configuration

Additional context

Purpur documentation: https://purpur.readthedocs.io/en/latest/

BONNe commented 4 years ago

From documentation:

Purpur is a fork of Paper used by the Pl3xCraft server. It contains many gameplay changes to suit our server that are deemed too wild to be included directly upstream into Paper.

So no, it should not be detected as Paper or Spigot fork. There are a lot of forks, as Paper and Spigot is open source projects, where everyone can just create their own versions. It does not mean, we should include it in "supported" versions.

As disclaimer mentions:

[04:03:01 WARN]: [BentoBox] ************ Disclaimer **************
[04:03:01 WARN]: [BentoBox] BentoBox may not be compatible with this server!
[04:03:01 WARN]: [BentoBox] BentoBox is tested only on the following Spigot versions:
[04:03:01 WARN]: [BentoBox] 1.14.4
[04:03:01 WARN]: [BentoBox] **************************************

It does not mean, BentoBox is not working. It just telling that this server version is not in our testing scope, and we cannot give any guarantee that BentoBox will work on this version.

Poslovitch commented 4 years ago

Answer has been provided by @BONNe.