BentoBoxWorld / Border

Adds a world border around islands
Eclipse Public License 2.0
13 stars 8 forks source link

Permission inconsistency for on join meta data check #120

Closed Kryniowesegryderiusz closed 9 months ago

Kryniowesegryderiusz commented 9 months ago

Expected behavior

Permission needed for border toggle command is [gamemode].border.toggle, but the meta data check looks for [addon-name].border.toggle

https://github.com/BentoBoxWorld/Border/blob/bcae4d987f1e7300fa3aad27381d1524fd255feb/src/main/java/world/bentobox/border/listeners/PlayerListener.java#L69

https://github.com/BentoBoxWorld/BentoBox/blob/887f09c41b09a7d329ab7b0ce449f5398faefe80/src/main/java/world/bentobox/bentobox/api/addons/Addon.java#L435-L437

    public String getPermissionPrefix() {
        return this.getDescription().getName().toLowerCase(Locale.ENGLISH) + ".";
    }

The same is for border type check.

Observed/Actual behavior

Permissions are different. It should be stated on wiki or more preferably changed to same (command) permission as if you dont have permission to change something by command it should be default.

Steps/models to reproduce

N/A

BentoBox version

N/A

Plugin list

No response

Other

No response