BentoBoxWorld / Boxed

A game mode where you are boxed into a tiny space that only expands by completing advancements
Eclipse Public License 2.0
15 stars 4 forks source link

Custom rewards for advancements #21

Open SeptyIsHere opened 3 years ago

SeptyIsHere commented 3 years ago

Description

Is your feature request related to a problem?

No, isn't related to a problem, my feature request is: Advancements Customrewards, example: You completed the advancement with crafting a diamond armor, you get an animal spawned on your box (or an item of the owner's choise)

Describe the solution you'd like us to implement.

Advancementsrewards.yml here you'll find every advancement that's enabled.

Describe alternatives you've considered.

I can't

Additional context

Like the real CaptiveMinecraft (box)

BONNe commented 3 years ago

(the idea is to create a separate addon that does it, but currently noone has a time for that)

BONNe commented 3 years ago

No, implementing it into the main plugin would mean that BentoBox core has a function that is not necessary for everyone. The idea of the BentoBox is to keep plugin with only main functions to run a gamemode, while addons allow enhancing each server.

If 'by plugin' you mean boxed gamemode, then it would not allow using the same advancement rewards in other GameModes without duplicating the code. Why SkyBlock should not be able to receive awards for advancements, or caveblock... or skygrid?

SeptyIsHere commented 3 years ago

Alright.

tastybento commented 3 years ago

I have been thinking of adding a rewards option to the advancements.yml file. Also, the idea is that what I learn from Boxed I plan to put into an addon for other game modes.

Fredthedoggy commented 3 years ago

This is more of a data pack function, as you can already add functions and commands to execute on advancement complete. I understand adding it here for simplicity, but it is already possible.