BentoBoxWorld / Boxed

A game mode where you are boxed into a tiny space that only expands by completing advancements
Eclipse Public License 2.0
15 stars 4 forks source link

Nether portal generating outside of border #36

Open bipedd opened 2 years ago

bipedd commented 2 years ago

Expected behavior

It should generate within the box border.

Observed/Actual behavior

Generates outside, tested multiple times so it was not a one time thing.one-time

Steps/models to reproduce

Create a nether portal on a new box, jump in and check if it is generated outside the portal.,

BentoBox version

16.11 23:14:42 [Server] INFO Running PAPER 1.17.1. 16.11 23:14:42 [Server] INFO BentoBox version: 1.17.3 16.11 23:14:42 [Server] INFO Database: JSON 16.11 23:14:42 [Server] INFO Loaded Game Worlds: 16.11 23:14:42 [Server] INFO boxed_world (Boxed): Overworld, Nether, The End* 16.11 23:14:42 [Server] INFO Loaded Addons: 16.11 23:14:42 [Server] INFO Border 3.2.0 (ENABLED) 16.11 23:14:42 [Server] INFO Boxed 1.2.1 (ENABLED) 16.11 23:14:42 [Server] INFO Chat 1.1.4 (ENABLED) 16.11 23:14:42 [Server] INFO InvSwitcher 1.11.0 (ENABLED) 16.11 23:14:42 [Server] INFO TwerkingForTrees 1.4.3 (ENABLED) 16.11 23:14:42 [Server] INFO Warps 1.11.1 (ENABLED)

Plugin list

No response

Other

2021-11-16_19 51 38

tastybento commented 2 years ago

This happens with brand-new (very small) boxes, but should not be an issue with realistic game play, i.e., where the player builds a portal once they have expanded the box.

bipedd commented 2 years ago

This happens with brand-new (very small) boxes, but should not be an issue with realistic game play, i.e., where the player builds a portal once they have expanded the box.

Can there be a thing where nether portals don't light until the box is big enough? As players can buy/give obsidian to others and go to the nether, see this, and report it thinking it's a bug. Would be a nice workaround to have. Could have a message sent in chat when the portal lighting is canceled that your box is not big enough, your box must be X by X to visit the nether.

BONNe commented 2 years ago

No, because there is no such thing as "too small" or "large enough".

Also, the portal is generated only when a player goes through the portal, and the end location is not known exactly before.

I would say, that we could stop teleporting to the nether until the border includes the portal location.

bipedd commented 2 years ago

No, because there is no such thing as "too small" or "large enough".

Also, the portal is generated only when a player goes through the portal, and the end location is not known exactly before.

I would say, that we could stop teleporting to the nether until the border includes the portal location.

Ah I see, I think that would be good then as well.