search

BentoBoxWorld / Boxed

A game mode where you are boxed into a tiny space that only expands by completing advancements
Eclipse Public License 2.0
15 stars 4 forks source link

Boxes generate in ocean #74

Open Projecki opened 2 months ago

Projecki commented 2 months ago

Expected behavior

Boxes generate not in ocean

Observed/Actual behavior

boxes generate in ocean sometimes

Steps/models to reproduce

make a box

BentoBox version

18:25:20 INFO: Running Invalid (UNIVERSESPIGOT) 1.20.4.

18:25:20 INFO: BentoBox version: 2.3.0 18:25:20 INFO: Database: MARIADB 18:25:20 INFO: Loaded Game Worlds: 18:25:20 INFO: boxed_world (Boxed): Overworld, Nether 18:25:20 INFO: Loaded Addons: 18:25:20 INFO: Border 4.3.0 (ENABLED) 18:25:20 INFO: Boxed 2.5.0 (ENABLED)

Plugin list

No response

Other

oceanbox4 oceanbox1 oceanbox2 oceanbox3

Projecki commented 2 months ago

Just released our box realm today, and getting a lot of reports of boxes spawning like the one in the screenshots

Projecki commented 2 months ago

image

image

structures generate at least! lol

tastybento commented 2 months ago

Do you have multiverse running? Usually when the boxes generate in variable places it's because the world generator isn't working. Multiverse unfortunately isn't compatible with Boxed. It works once but on server reboot it doesn't. If you don't have Multiverse do you have something similar?

Projecki commented 2 months ago

Yes, I do use multiverse.

I attempted to use MyWorlds but the plugin would not load on my setup. Their dev team wasn’t very helpful

besides, is swapping to my worlds, assuming I can get it working, safe with an already in production server?

Projecki commented 2 months ago

I’ve My Worlds loading properly now on my test environment

are there any implications to swapping to My Worlds from Multiverse with my production Boxed server? Or should it be safe to drop it in

Projecki commented 2 months ago

https://youtu.be/XdzaJ_dSIdE

Major issues using My Worlds now

MyWorlds 1.20.6-v1-294 BKCommonLib 1.20.6-v1-1749

Boxes generate with no blocks aside from the initial blueprint!

tastybento commented 2 months ago

Do you need a multi world plugin? It's not needed just for Boxed.

Projecki commented 2 months ago

I do weekly resource world resets, where we use a world manager plugin to delete the resource world and create a new one & then Chunky is scripted to generate the chunks.

I can give no multiverse or my worlds a try, though.

tastybento commented 2 months ago

https://youtu.be/XdzaJ_dSIdE

Major issues using My Worlds now

MyWorlds 1.20.6-v1-294

BKCommonLib 1.20.6-v1-1749

Boxes generate with no blocks aside from the initial blueprint!

Also, your seed worlds may be messed up due to the Multiverse issue. What happens is that a seed world is created to copy from to the real world. But if the generator was broken then that could be messed up. If MyWorlds works fine on a clean test server then that's the issue.

Either way, you will need to solve the seed world issue if you don't want to just restart everything. You should run tests but essentially to reset you remove the additional seed world folders inside the main Boxed worlds and let them regenerate.

Projecki commented 2 months ago

I see, I didn't understand that it was the initial seed world generation that could be the issue.

Correct, my worlds clean install seems to work fine - though limited testing

I'll try to replicate the issue on my dev environment, and then test deleteing the seed world folders inside the boxed worlds to let them regenerate. Thanks

tastybento commented 2 months ago

And just to explain what is happening in the video- the island was made in a spot that previously had been regenerated. The seed world was void at that position so the spot was made void when the island was deleted. Then a new island was put in it.

tastybento commented 2 months ago

Another less radical remedy in game make islands with your character and then unregister them and make another. Continue until you get to "good" locations that have the expected environment. Then do not delete or purge those other spots. Then when players make new islands they will always be outside of the bad generation area.

Projecki commented 2 months ago

to confirm, the folders to delete are:

Boxed_World/seed Boxed_World/seed_nether

Projecki commented 2 months ago

image

I migrated dev to My worlds & deleted the seed folders above

Despite this, the void boxes are still being used

Projecki commented 2 months ago

image

even with no world manager plugin installed at all - BentoBox still uses old bad void boxes

Projecki commented 2 months ago

Okay, so if I unregister these void boxes they won't be used anymore.

I need to confirm no new void boxes are being generated. Let me start tracking coordinates

Projecki commented 2 months ago

https://youtu.be/DM1XX4IWkxw

I attempted to unregister all "bad boxes"

However, as you can see in this video - boxes generate in a linear path through the world. They go from jungle, to middle of the ocean, to jungle, to middle of the ocean etc.

This is with a world that was initially generated by multiverse, but has had Boxed_world/seed deleted & regenerated without multiverse or my worlds installed on the server

Projecki commented 2 months ago

https://youtu.be/xeS1TNHRVOE

Here is a fresh install

I reset my MariaDB I reset boxed_world

I generated fresh world with only BentoBox, no multiverse nor myworlds installed

Still - boxes generate off-center from the expected spawn point.

tastybento commented 2 months ago

So, is this a world different from the one that it generates by default? Are any of the configs changed at all?

Projecki commented 2 months ago

No, this is the default BentoBox/Boxed seed, the only things I've changed in config are irrelevant to this i would think:

numbers of resets, default protection flags,

potentially: size of boxes

by default, bentobox has 500x500 boxes I believe

my boxes are smaller: 300x300

Projecki commented 2 months ago

https://pastebin.com/nN6eQ5n9

my boxed configuration, for reference

Projecki commented 2 months ago

Yo!

Area-radius needs to be divisible by 16

Using area-radius 320, or 160 both fix issue. My current area radius 150, it breaks.

Not sure how I can fix my currently released server, however...

tastybento commented 2 months ago

Ahm yes. The area radius has to be in whole chunks. I didn't think of that, but it's obvious now I think about that. I should mention that in the config.

Rectifying the server is going to be difficult because if the island sizes are different then BentoBox will refuse to start. I can't think of a way except for a reset, sorry. How many boxes have been made so far?

Projecki commented 2 months ago

Around 6,000 boxes have been made, lol

I think we're just gonna tell players to live with it

The void boxes seem to be fixed by switching to my_worlds + resetting seed world - so our remaining issue is ocean boxes.

Projecki commented 2 months ago

Going to release a 2nd Boxed server, we need the player slots. On this new server we'll make sure to use radius 160

Projecki commented 2 months ago

@tastybento I have done more testing on generating "void boxes" specifically, like in #65

Using MyWorlds + having an area radius that is not divisible by 16 results in void boxes when boxes that players have reset are reused next server restart by BentoBox.

So MyWorlds & Multiverse both have this issue.

I'm not sure how helpful this is, since using a bad area-radius number is the nucleus for all my problems.

But I'm not able to reset my server, we have thousands of boxes. So I'm still trying to find a way to fix these issue for my players

& not using a world manager is unrealistic - vanilla MC can only load 3 worlds I believe? I need to manage my resource world specifically, among other things.