Optional Generators - Githubissues

BentoBoxWorld / CaveBlock

CaveBlock addon for BentoBox. An interesting variation from Skyblock, where your goal is to survive in a cube of stone!

Eclipse Public License 2.0

16 stars 6 forks source link

Optional Generators #67

Closed HSGamer closed 2 years ago

HSGamer commented 2 years ago

Changes

Back to the old block generators so that we can keep the current settings
Move the new block populator to be an BlockPopulator, and an option in the settings
Possibly fix #66 as I think we can't set the block type twice at the same location
An hasAI option for ENTITY, so the format will be ENTITY:<type>:<percent>:<amount>[:<hasAI>]

Notice

The new block generator is not customizable. Will you do it in the future?

HSGamer commented 2 years ago

Any suggestion?

tastybento commented 2 years ago

Thanks for the PR! I was working on a 1.17 generator too. Unfortunately due to IRL work I don't have time to work on it much so I just made #68 . Please tell me what you think.

HSGamer commented 2 years ago

Thanks for the PR! I was working on a 1.17 generator too. Unfortunately due to IRL work I don't have time to work on it much so I just made #68 . Please tell me what you think.

My PR moved your ore generator to an BlockPopulator, so that we could give the user to choose the old settings or the new world generator. If you changed anything in your new PR #68, from my perspective, you should merge this PR and then apply your changes to the new BlockPopulator named NewMaterialPopolator.

BONNe commented 2 years ago

I am confused a bit. What is the difference between both PRs?

HSGamer commented 2 years ago

As I saw, you just re-opened the old PR #61. Did you change anything new?

HSGamer commented 2 years ago

All populators are updated to the new API. It's good to merge now.