Error with File Generation from challenges, and Iron Age Challenge not completing

Weymouth87 commented 4 years ago

Description

Describe the bug

Iron age challenge saying that there are items missing when there is not. Tried to use /[admin_command] challenges defaults generate and received an error.

Steps to reproduce the behavior

Expected behavior

Screenshots and videos (Optional)

https://prnt.sc/tohng3 https://gyazo.com/3c846e3bdd1ccc21e627ba348d54c501 Archive.zip

Environment

Output of `/bbox version` (Mandatory)

Warps 1.10.0 (ENABLED)
25.07 22:06:48 [Server] INFO TwerkingForTrees 1.4.1-SNAPSHOT-b46 (ENABLED)
25.07 22:06:48 [Server] INFO MagicCobblestoneGenerator 2.1.0-SNAPSHOT-b154 (ENABLED)
25.07 22:06:48 [Server] INFO Limits 1.14.0 (ENABLED)
25.07 22:06:48 [Server] INFO Level 2.3.4-SNAPSHOT-b403 (ENABLED)
25.07 22:06:48 [Server] INFO Greenhouses 1.2.0-SNAPSHOT-b242 (ENABLED)
25.07 22:06:48 [Server] INFO DimensionalTrees 1.6.1-SNAPSHOT-b81 (ENABLED)
25.07 22:06:48 [Server] INFO ControlPanel 1.13.0-SNAPSHOT-b38 (ENABLED)
25.07 22:06:48 [Server] INFO CheckMeOut 1.0.2 (ENABLED)
25.07 22:06:48 [Server] INFO Chat 1.1.0-SNAPSHOT-b30 (ENABLED)
25.07 22:06:48 [Server] INFO Challenges 0.8.4-SNAPSHOT-b428 (ENABLED)
25.07 22:06:48 [Server] INFO BSkyBlock 1.14.1-SNAPSHOT-b670 (ENABLED)
25.07 22:06:48 [Server] INFO Biomes 1.13.0-SNAPSHOT-b180 (ENABLED)
25.07 22:06:48 [Server] INFO Loaded Addons:
25.07 22:06:48 [Server] INFO bskyblock_world (BSkyBlock): Overworld, Nether, The End
25.07 22:06:48 [Server] INFO Loaded Game Worlds:
25.07 22:06:48 [Server] INFO Database: JSON
25.07 22:06:48 [Server] INFO BentoBox version: 1.15.0-SNAPSHOT-b1845
25.07 22:06:48 [Server] INFO Running PAPER 1.15.2.

Plugins (Optional)

Plugins (72): ActionHealth*, Advanced_Drop_Party, AdvancedAnnouncement*, AdvancedEnchantments, AdvancedPortals, ArmorStandTool, AsyncWorldEdit, AutoPickup, BannerMaker, BentoBox, BestTools, BookShelf, BottledExp, BuycraftX, ChatColor, ClearLag, CMI, CMIPaperLib, CosmicFunds, CrazyAuctions, CrazyCrates, CrazyEnvoy, CropClick*, CustomHeads*, DeluxeChat, DeluxeMenus, DeluxeTags*, EditableSign, Elevator, Essentials, EssentialsChat, EssentialsSpawn, EternalLight, FlightControl, Graves, HolographicDisplays, HolographicExtension*, HolographicScoreboard*, HubParkour, InteractionVisualizer, Jackpot, LeaderHeadsRevamped, LightAPI, LuckPerms, Multiverse-Core, Multiverse-NetherPortals, Multiverse-Portals, NerfPhantoms, PlaceholderAPI, PlugMan, Prism, ProtocolLib, PvPManager, ShopChest, ShopGUIPlus, Statz, StreamingDrops, TabList, TouchscreenHolograms, TreeFeller, VarLight, Vault, ViaVersion, VoidGenerator, VoidTeleport, WildStacker, WildStackerMobsPatch, WolfyUtilities, WorldEdit, WorldGuard, XPBoost, zDiscord*

Additional context (Optional)

tastybento commented 4 years ago

What error do you get?

BONNe commented 4 years ago

From Discord https://pastebin.com/Ph9XMWHJ

BONNe commented 4 years ago

For some reason, in the database, you provided some challenges contains NULL items. That is the reason for crashes.

I latest build I add protection methods, that will not allow loading these challenges.

I tried to do the IronAge challenge, and I was successful. However, there is a way how to make that challenge is not working:

if an item has a custom name it will not be considered as a valid item
if an item has an enchantment, it will not be considered as a valid item
if an item has been damaged, it will not be considered as a valid item

Weymouth87 commented 4 years ago

Thank you :)

Would the items be accepted if the gear was previously damaged but repaired fully via an anvil?

Weymouth87 commented 4 years ago

Just tested with brand new armour and it works, thank you. The player was using repaired armour instead :)

BONNe commented 4 years ago

I will try to fix that in next release.

BentoBoxWorld / Challenges