search

BentoBoxWorld / Greenhouses

BentoBox Add-on to enable personal biomes in a glass greenhouse
Eclipse Public License 2.0
13 stars 9 forks source link

Server freezes when trying to make greenhouse with no glass blocks near player. #31

Closed maciejnierzwicki closed 4 years ago

maciejnierzwicki commented 4 years ago

Description

Describe the bug

After typing /is greenhouse and picking one of available biomes server freezes and shuts down. This happens when player is not surrounded with glass blocks or there are no glass blocks near player at all.

Steps to reproduce the behavior

  1. Go to your island. Make sure there are no glass blocks nearby.
  2. Type /is greenhouse while standing on your island.
  3. Pick one of available biomes.

Screenshots and videos

Expected behavior

Server not freezing after trying to pick biome from /is greenhouse

Environment

Server

Plugins

AdvancedAchievements, AdvancedRegionMarket, BattleArena, BentoBox, BlockEntityLimiter, BlockInteractRegenerate*, BungeeTabListPlus*, ChangeSlots*, ChestShop, Citizens, CrackShot, CustomCrafting, DailyChests, DiscordSRV, dynmap*, GlowAPI*, GrindstonePatch*, GroupChat*, GUIWarps, HolographicDisplays, HolographicScoreboard*, IllegalStack, IPWhitelist*, LockettePro, LogBlock, LuckPerms, MicroJump*, MineResetLite, MineShop, MMHologramTest*, MobArena, MobPerChunkLimiter*, MultiCommand*, Multiverse-Core, Multiverse-Portals, MWCore, MWDiscordBots*, MyCommand, MyPet, MythicMobs, MythicMobsExtension, MythicMobSpawners, NoSpawnerChange, PacketListenerApi*, PlaceholderAPI*, PlugMan*, PortalUsePreventer*, PremiumVanish, PrivateMessages, ProtocolLib*, RFChairs, ServerSigns, SignColorPreventer, SimpleStoneDrop, SimpleTrading, SkinsRestorer, Vault, VillagerSpawner, WG-GUI, WolfyUtilities, WorldBorder, WorldEdit, WorldGuard, WorldGuardExtraFlags, xAuctions

BentoBox setup

BentoBox and Addons
Running PAPER 1.14.4.
BentoBox version: 1.8.0
Database: YAML
Loaded Game Worlds:
bskyblock_world (BSkyBlock): Overworld, Nether, End
Loaded Addons:
BSkyBlock 1.8.0 (ENABLED)
Greenhouses 0.4.5-SNAPSHOT (ENABLED)
Level 1.8.0 (ENABLED)
Warps 1.8.1 (ENABLED)
Configuration

Additional context

Server log when it's freezed:

https://pastebin.com/ccpgked0

Greenhouses uses default configuration.

tastybento commented 4 years ago

The search range is probably too large and the chunks are being created everywhere it’s looking. I’ll optimize.