Closed AngieC233 closed 1 year ago
tastybento
commented
2 years ago I think you have a greenhouse in your database that is corrupted or was maybe made in a different world that doesn't exist any more. So as players move around, Greenhouse checks if the player is in that greenhouse and that generates an error. Can you zip up your BentoBox/database folder and drag and drop it into a reply box here? I'll check it and try and fix this.
AngieC233
commented
2 years ago tastybento
commented
2 years ago All the greenhouses files in the database are missing the bounding box info in them. I suspect they were made with an older version of greenhouses. There's no real way to fix them except to delete the greenhouse database files and have players remake the greenhouse with the greenhouse command. So:
/is greenhouse and make the greenhouse again.AngieC233
commented
2 years ago Deleted the greenhouse database files. I think it did re-solved the issues. So far no more errors spamming. I'll close this report. Will let you know if the problem persist. Thank you so much
AngieC233
commented
2 years ago Some how after each server restart, the errors re-surfaced.
Took these steps several times:
tastybento
commented
2 years ago Okay I'll look at this again.
tastybento
commented
2 years ago Hmm, well, I can't seem to replicate this. Can you share your Greenhouses database folder again?
AngieC233
commented
2 years ago So far created only 1 greenhouse Greenhouse.zip
tastybento
commented
2 years ago @AngieC233 I'm stumped. I cannot replicate this and in reviewing all the code, I cannot see where such an issue could occur. In the file you sent, the BoundingBox entry is missing so the greenhouse literally has no coordinates. This shouldn't happen and I'm not sure why it would. It might be an error caused during loading or saving of the greenhouse file. Please try the latest snapshot version. You'll need stop the server and delete the Greenhouses folder or file, then recreate the greenhouse.
The latest snapshot is here: https://ci.codemc.io/job/BentoBoxWorld/job/Greenhouses/
It'll be interesting to see what errors you get (if any) with this version. Look out for errors on the loading after your daily restart. Also, how do you do the restart?
BONNe
commented
2 years ago @tastybento May be the issue is with saving data at the shutdown?
AngieC233
commented
2 years ago I'll try this snapshot, keep you updated later. Thank you
I fully /stop the server and then /start it back from console
AngieC233
commented
2 years ago Alright, here's what I have done: 1) Stop the server and deleted the Greenhouse folder and data 2) Put in the latest snapshot jar 3) Start the server 4) Re-create /is greenhouse
After scheduled server restart - stop and start, the greenhouse no longer works (couldn't load the greenhouse) and here's the start up errors: https://pastebin.com/SbqUE0h9 Greenhouse.zip
The shutdown logs for BentoBox if you need it: https://pastebin.com/pEGxbRRH
tastybento
commented
2 years ago May be the issue is with saving data at the shutdown?
Yes, maybe. It's weird that it's only BoundingBox that is being nulled though.
@AngieC233 Please try with the latest snapshot. This version doesn't save greenhouses at all except when they are created. If there are still errors, then that'll indicate that the problem is with the initial construction. If not, then it indicates that the data structure of the greenhouses is being destroyed before saving on shutdown, which is weird, but we have seen something like it before. You'll need to delete the database again when the server is off and then make the greenhouse.
AngieC233
commented
2 years ago Here we go. Deleted the database and uploaded the latest snapshot . Re-create greenhouse. After scheduled server re-start, there are errors
Expected behavior
Expect no errors on console
Observed/Actual behavior
When player enter Skyblock world, errors will start to spam. The errors stop when they leave Skyblock world
https://pastebin.com/2V7R7qBT
Steps/models to reproduce
Stopped server and updated Greenhouses to lasted snapshot and regenerated biome.yml. However, when players go to Skyblock world errors still spammed console
As soon as player leaves Skyblock world to overworked Survival, the errors stopped
BentoBox version
[Sat, 18. Dec 2021 06:20:09 UTC INFO] Running PAPER 1.18.1. [Sat, 18. Dec 2021 06:20:09 UTC INFO] BentoBox version: 1.19.0 [Sat, 18. Dec 2021 06:20:09 UTC INFO] Database: JSON [Sat, 18. Dec 2021 06:20:09 UTC INFO] Loaded Game Worlds: [Sat, 18. Dec 2021 06:20:09 UTC INFO] bskyblock_world (BSkyBlock): Overworld, Nether, The End [Sat, 18. Dec 2021 06:20:09 UTC INFO] Loaded Addons: [Sat, 18. Dec 2021 06:20:09 UTC INFO] Biomes 1.14.0 (ENABLED) [Sat, 18. Dec 2021 06:20:09 UTC INFO] BSkyBlock 1.15.2 (ENABLED) [Sat, 18. Dec 2021 06:20:09 UTC INFO] Challenges 1.0.0-SNAPSHOT-b473 (ENABLED) [Sat, 18. Dec 2021 06:20:09 UTC INFO] ControlPanel 1.13.0 (ENABLED) [Sat, 18. Dec 2021 06:20:09 UTC INFO] DimensionalTrees 1.6.0 (ENABLED) [Sat, 18. Dec 2021 06:20:09 UTC INFO] Greenhouses 1.6.1-SNAPSHOT-b311 (ENABLED) [Sat, 18. Dec 2021 06:20:09 UTC INFO] Level 2.8.1 (ENABLED) [Sat, 18. Dec 2021 06:20:09 UTC INFO] Limits 1.17.2 (ENABLED) [Sat, 18. Dec 2021 06:20:09 UTC INFO] MagicCobblestoneGenerator 2.4.0-SNAPSHOT-b232 (ENABLED) [Sat, 18. Dec 2021 06:20:09 UTC INFO] Warps 1.11.1 (ENABLED)
Plugin list
No response
Other
No response