search

BentoBoxWorld / Greenhouses

BentoBox Add-on to enable personal biomes in a glass greenhouse
Eclipse Public License 2.0
13 stars 9 forks source link

Fixed issue where greenhouses could not be created below y=0 #95

Closed Zorua162 closed 1 year ago

Zorua162 commented 1 year ago

Fixed issue that has been occurring since world lower limit was lowered. Should be relatively simple, and tested in game to work, however I will admit I am confused why the minX and minZ only changed by 11 instead of 64 due to the extra height of the greenhouse in the "testFindWalls" test.

This is in reference to issue #94

BONNe commented 1 year ago

This is not entirely correct. World height changes applies only to the default overworld. Also it is possible to set world lower and higher via world editing.

The proper solution would be to use World#getMinHeight().

Zorua162 commented 1 year ago

Thanks for the heads up, I've locally made that fix now and have the tests passing again, I will test when I get back tonight to ensure that the fix has worked as expected before updating this push request.

Zorua162 commented 1 year ago

Updated to include the above suggestion and tested in both the overworld and the nether.