search

BentoBoxWorld / InvSwitcher

World inventory switcher. Handles health, exp, advancements, inventory, etc.
Eclipse Public License 2.0
2 stars 5 forks source link

Advancement notifications #12

Closed BONNe closed 9 months ago

BONNe commented 3 years ago

Description

Describe the bug

When player switch gamemodes, server get notified with about new advancements, however, it just adds advancements which are in gamemode. So rapidly switching gamemodes just spams the whole server with advancement unlock messages.

Steps to reproduce the behavior

Get some advancements in one gamemode, while different ones in another gamemode. Then switch gamemodes.

Expected behavior

The server should not be notified about unlocked advancements if the player switches game modes and it is just restoring advancements for a given game mode.

Screenshots and videos (Optional)

bug

Environment

Output of /bbox version (Mandatory)

version

Additional context (Optional)

Tested on tastybento server.

tastybento commented 3 years ago

There is a gamerule that turns off advancement announcements. This is the simplest way to prevent the spamming and I expect most real servers have this switched off anyway. I am not sure that it's possible to prevent the server announcement via Bukkit API. Any ideas?