BentoBoxWorld / InvSwitcher

World inventory switcher. Handles health, exp, advancements, inventory, etc.
Eclipse Public License 2.0
2 stars 5 forks source link

Plugin is affecting worlds that are not listed under config worlds #21

Closed trwnh closed 3 years ago

trwnh commented 3 years ago

Description

Describe the bug

Teleporting to other worlds wipes inventory XP and advancements. Teleporting back to previous world does not restore inventory XP or advancements.

Steps to reproduce the behavior

Pre-requisites: BentoBox, BentoBox/InvSwitcher, Multiverse-Core

  1. Be in world
  2. /mvtp creative
  3. Data wiped
  4. /mvtp world or /spawn
  5. Data not restored

Alternatively, with BSkyBlock and EssentialsX added to pre-requisites:

  1. Be in world
  2. /is
  3. Data wiped
  4. /back
  5. Data not restored

This obviously makes Skyblock unplayable as your inventory will just be wiped entirely instead of being restored when you switch back to Skyblock.

Expected behavior

Inventory / XP / Advancements / etc should be restored successfully

Environment

Output of /bbox version (Mandatory)
Running PAPER Invalid.
BentoBox version: 1.16.2
Database: JSON
Loaded Game Worlds:
bskyblock_world (BSkyBlock): Overworld, Nether, The End
Loaded Addons:
Biomes 1.14.0 (ENABLED)
Border 3.1.1 (ENABLED)
BSkyBlock 1.14.4 (ENABLED)
Challenges 0.8.4 (ENABLED)
Chat 1.1.3 (ENABLED)
ControlPanel 1.13.0 (ENABLED)
ExtraMobs 1.11.0.3 (ENABLED)
Greenhouses 1.5.3 (ENABLED)
InvSwitcher 1.10.0 (ENABLED)
IslandFly 1.8.1 (ENABLED)
Level 2.6.3 (ENABLED)
TwerkingForTrees 1.4.1 (ENABLED)
Warps 1.10.2 (ENABLED)

Additional context (Optional)

Reproducible in a fresh install of Paper 1.17 -- have not tested Paper 1.16.5 yet.

tastybento commented 3 years ago

Thanks for the report. Unfortunately, I cannot replicate this yet. I tried on a fresh install of 1.17 with BentoBox, InvSwitcher, and Multiverse:

> bbox v
[08:52:26 INFO]: Running PAPER 1.17.
[08:52:26 INFO]: BentoBox version: 1.17.0-SNAPSHOT-LOCAL
[08:52:26 INFO]: Database: JSON
[08:52:26 INFO]: Loaded Game Worlds:
[08:52:26 INFO]: Loaded Addons:
[08:52:26 INFO]: InvSwitcher 1.10.0 (DISABLED)
[08:52:31 INFO]: UUID of player BoxManager is 36b2293a-ac0a-4f73-bc35-b12af97bee2b
[08:52:32 INFO]: BoxManager joined the game
[08:52:32 INFO]: BoxManager[/127.0.0.1:52407] logged in with entity id 669 at ([world]-176.0, 64.0, 96.0)
[08:52:41 INFO]: BoxManager issued server command: /mvtp creative
[08:52:49 INFO]: BoxManager issued server command: /mvtp world
[08:52:55 INFO]: BoxManager lost connection: Disconnected
[08:52:55 INFO]: BoxManager left the game
> plugins
[08:52:59 INFO]: Plugins (4): BentoBox, Multiverse-Core, WorldBorderAPI, WorldGeneratorApi

https://user-images.githubusercontent.com/4407265/123551151-744e9180-d725-11eb-8559-0a516c569f4b.mov

I'm not sure why you are seeing inventory being changed. What is your InvSwitcher config.yml? Do you have any inventory management plugins at all?

tastybento commented 3 years ago

I managed to replicate it. This is a bug.

tastybento commented 3 years ago

Thanks for the report - this occurred when there were game worlds loaded. I'll do a new release.