Closed myavuzokumus closed 4 years ago
I can't replicate this right now - it all seems to work.
Players who are Op or who have bskyblock.island.flybypass
permission can fly outside the border. Maybe this player has this permission or a * permission of some kind?
No. Players do not have these permission.
I need more info -
I may have to give you a debut build of the addon. Okay? It would probably be easiest.
Ok.
We would need that output in English though.
I'll prepare a debug build that will tell us what is going on.
IslandFly-1.7.0-SNAPSHOT-LOCAL.jar.zip Please try this and share the console log. Have the player exit the island like in the video and then share the log that results. Thanks!
Thanks. Please try this version: IslandFly-1.7.0-SNAPSHOT-LOCAL.jar.zip
Another error message
Does not relate to fly addon! Please create a separate issue in BentoBox repository.
@OverBrave Ignore the error message - that is fixed in latest bentoBox build and unrelated.
In regards to the fly debug, let me check the sequence of events to confirm:
/island fly
command and is then able to fly outside the boundaryQuestion: it looks like your islands go right next to each other - correct? What is the island distance and island protection sizes?
(BTW, in future, please copy and paste text instead of screenshot - thanks!)
BTW, if the above is true, then I expect the player is jumping over the island boundary check and then typing fly. IslandFly checks boundaries only when the player exits the island boundary and does not check continuously.
No. BSkyblock Config.;
distance-between-islands: 75 protection-range: 15
Is this sequence correct though:
You give xEnder permission to fly Ender then exits the island boundary Ender then issues the /island fly command and is then able to fly outside the boundary Ender then returns to the island
Yes.
Should be fixed now.
There's a problem. Can you check that out? Red text warns that it will close. The purple text indicates that the flying mode is back on. https://streamable.com/ycbs1
This is happening because IslandEvent.IslandExitEvent
is triggered when leaving the range that is already set for your island, but if the distance between islands is not as same as range:
Island is = addon.getIslands().getIslandAt(user.getLocation()).orElse(null);
will still return the closest island, while it should return null (if user is beyond protection range).
I see no API that only checks if user is within a protection range of any island, and not only his own. public boolean userIsOnIsland(World world, User user)
will only check for user's own island, but not for others as well. The problem now is that the IslandFly supports using fly command on other islands too.
But he can fly to another island and fly mode does not turn off. Anyway, when he enters another island, can you turn off the flight mode if the island doesn't belong to him?
The problem was of other nature. I opened a pull request that fixes it. Found the part of API I needed!
The latest update also is effective on op. #95 dev build
Okay, so I should ignore Ops.
Should be fixed now with latest build.
Screenshots and videos
https://streamable.com/0pgb7
Server
Plugins
BentoBox setup
BentoBox and Addons
Extra:
Players cannot fly on the nether and end islands. Each time "Flying mode is turned on." says.