Dragon_Head and Dragon_Wall_Head not adding to island value

dramasailor commented 3 years ago

Describe the issue

Placing dragon heads on the ground or the wall doesn't appear to add any island value upon running /is level.

Steps to reproduce the behavior

I ran /is level, noted down my level Placed 15 Dragon Heads (10 on the ground, 5 on a wall). Double checked config, they have a block value of 15,000. Ran /is level again. Island level didn't change.

Expected behavior

Several hundred levels should have been added. With a requirement of 150-250 points per level, it should have added a significant amount.

Screenshots and videos (Optional)

Environment

Output of `/bbox version` (Mandatory)

bbox version
[16:28:41 INFO]: Running Invalid (TUINITY) 1.16.3.
[16:28:41 INFO]: BentoBox version: 1.15.1-SNAPSHOT-b1877
[16:28:41 INFO]: Database: JSON
[16:28:41 INFO]: Loaded Game Worlds:
[16:28:41 INFO]: bskyblock_world (BSkyBlock): Overworld, Nether, The End
[16:28:41 INFO]: Loaded Addons:
[16:28:41 INFO]: Biomes 1.13.0-SNAPSHOT-b188 (ENABLED)
[16:28:41 INFO]: Border 1.0.9 (ENABLED)
[16:28:41 INFO]: BSkyBlock 1.14.1-SNAPSHOT-b673 (ENABLED)
[16:28:41 INFO]: Chat 1.1.1-SNAPSHOT-b34 (ENABLED)
[16:28:41 INFO]: ControlPanel 1.13.0-SNAPSHOT-b42 (ENABLED)
[16:28:41 INFO]: DimensionalTrees 1.6.1-SNAPSHOT-b82 (ENABLED)
[16:28:41 INFO]: Greenhouses 1.4.0-SNAPSHOT-b248 (ENABLED)
[16:28:41 INFO]: IslandFly 1.8.0 (ENABLED)
[16:28:41 INFO]: Level 2.5.0-SNAPSHOT-b418 (ENABLED)
[16:28:41 INFO]: Likes 2.1.0-SNAPSHOT-b29 (ENABLED)
[16:28:41 INFO]: MagicCobblestoneGenerator 2.2.0-SNAPSHOT-b161 (ENABLED)
[16:28:41 INFO]: TwerkingForTrees 1.4.1 (ENABLED)
[16:28:41 INFO]: Upgrades 0.2.0-SNAPSHOT-b66 (ENABLED)
[16:28:41 INFO]: Warps 1.10.1-SNAPSHOT-b268 (ENABLED)

Plugins (Optional)

Plugins (110): AdvancedAchievements, AdvancedArmorStands, AntiDisconnectSpam, AntiRedstoneLag*, AuctionHouse, BedrockMiner, BentoBox, BetterSlimeChunk*, BlockLocker, Brewery, BuycraftX, ChatColor2*, ChatInjector, ChatManager, ChatReaction, CheaperPhysicsEvent, ChestCommands, ChestShop, ChestShop-LegacyIds, Citizens, CitizensCMD, ClearLag, Commander*, CompatNoCheatPlus*, ConditionalCommands, CoreProtect, Craftimize-Vigil*, DiscordSRV, DisplayItem, Duels, EnchantGui, EpicRename, Essentials, EssentialsAntiBuild, EssentialsChat, EssentialsGeoIP, EssentialsProtect, EssentialsSpawn, ExploitFixer, FarmLimiter, FeatherBoard*, FreeCamDupePatch*, Gamerules*, GSit, HamsterAPI*, HolographicDisplays, HolographicExtension*, Hopperfilter, ICClass, IllegalStack, JetsMinions, KitPreview, LibsDisguises, LuckPerms, mcMMO, MessageAnnouncer, MineableSpawners, MiniaturePets*, MobCoins, MorphRedeem, Multiverse-Core, MVdWPlaceholderAPI*, MyCommand, NoCheatPlus, OldCombatMechanics, PlaceholderAPI, Plan, PlayerHeads, PlayerParticles, PlayerPoints*, PlayerPointsPAPIExpansion*, PlayerVaults, PlugMan, ProtocolLib, PyroFishingPro, QuadrexKitGUI*, RedstoneClockDetector*, ServerLog, ShopGUIPlus, SignEdit*, SimpleChatFilter*, SirBlobmanCore, SnowballDamage*, spark, SpecializedCrates, SpleefX, SQLibrary*, SSX-Connector*, StableMaster, Stacker, StaffChatReloaded, SuperbVote, TAB, TradePlus, Vault, ViaBackwards, ViaRewind, ViaVersion, VoidGenerator, VoidSpawn, Votifier, VotingPlugin, WildTools, WolfyUtilities, WorldBorder, WorldBorderAPI, WorldEdit, WorldGuard, WorldGuardExtraFlags, XP-Deposit*

Additional context (Optional)

Limits addon not installed No Limits listed in blockconfig.yml. Changed file type and attached here. blockconfig.txt

charlyg31 commented 3 years ago

image png 0f4ab9b374a85bf1a616c7e251de3836

image png e99dda415e90c59828efe64c274bbf34 Add level with blocs in the top of the head

tastybento commented 3 years ago

This is caused by a bug in the chunk snapshot method getHighestBlockYAt() that ignores heads. It's part of the server so it's not going to change. I've had to work around it. If you place blocks on top of the heads you will see that they are counted.

I'll upload a fix - thanks for the report.

BentoBoxWorld / Level