Prevented breeding way under limit

x1p commented 4 years ago

Description Cows won't breed while their number is way under the limit. It seems to involve many islands, but not all. In order to eliminate the possible cause is tried:

reset all island flags
limits recount
inspect database files but I couldn't find storage of limits The counting of animals in the limits gui is consistant with the number of animals on the island. The gui reflects the correct number of animals e.g. 8 / 16 cows

Steps to reproduce the behavior:

Existing islands with a number of cows
Player tries to breed
Cows are fed, hearts appear, XP drops, no baby
Staff member comes along, tries to breed/spawn with spawn_egg which is prevented as well.
Player tries ./is limits recount and repeats steps 2-4, no luck
Admin (OP) tries ./bsb limits calc (playername) and repeats steps 2-4, no luck
Admin (OP) can breed and spawn cows with spawn_egg. (workaround)

Expected behavior Consistent breeding until limit is reached

Screenshots If applicable, add screenshots to help explain your problem.

Server Information:

[Please complete the following information:]

Database being used (YAML, JSON, MySQL, MongoDB): [JSON]
OS: [LINUX]
Java Version: [Java 11]
BentoBox version: [1.15.1 b1869]

Addons installed?

Running Invalid (PURPUR) 1.16.3.
BentoBox version: 1.15.1-SNAPSHOT-b1869
Database: JSON
Loaded Game Worlds:
bskyblock_world (BSkyBlock): Overworld, Nether, The End
Loaded Addons:
Biomes 1.13.0 (ENABLED)
BSkyBlock 1.14.1-SNAPSHOT-b673 (ENABLED)
Challenges 0.8.4-SNAPSHOT-b428 (ENABLED)
Level 2.4.2-SNAPSHOT-b417 (ENABLED)
Limits 1.15.0-SNAPSHOT-b236 (ENABLED)
MagicCobblestoneGenerator 2.2.0-SNAPSHOT-b160 (ENABLED)
Warps 1.10.1-SNAPSHOT-b267 (ENABLED)

Other plugins? [Do '/plugins' and copy/paste from the console] No mob limiting plugin what so ever

tastybento commented 4 years ago

I can't replicate this right now - do the players receive a message saying that the limit has been reached when they try to breed the animals? I did not see that in your report:

x1p commented 4 years ago

That message appears indeed but the limit was not reached according to the limits GUI and confirmed by manually counting. Screenshot 2020-09-26 213842 Screenshot 2020-09-26 213921

tastybento commented 4 years ago

Please try this version that has debug. Try to spawn a cow and see what it says in the console. Please copy and paste here. It should look something like this:

[17:01:19 INFO]: [BentoBox] DEBUG: Island LimitAmount = -1
[17:01:19 INFO]: [BentoBox] DEBUG: Global LimitAmount = 16
[17:01:19 INFO]: [BentoBox] DEBUG: Count = 16

Limits-1.15.0-debug-SNAPSHOT-LOCAL.jar.zip Also, share your config.yml because I'd like to see what it is.

tastybento commented 4 years ago

On the off-chance that this is a duplication issue - please try this version too and see if it helps: Limits-1.15.0-debug-SNAPSHOT-LOCAL.jar.zip

x1p commented 4 years ago

First plugin's output when trying to spawn: (only 1 attempt to spawn, the rest of the debug messages is prob. from other entities)

[08:20:45 INFO]: [BentoBox] DEBUG: Island LimitAmount = -1
[08:20:45 INFO]: [BentoBox] DEBUG: Global LimitAmount = 16
[08:20:45 INFO]: [BentoBox] DEBUG: Count = 5
[08:20:45 INFO]: [BentoBox] DEBUG: Checking group limits
[08:20:47 INFO]: [BentoBox] DEBUG: Island LimitAmount = -1
[08:20:47 INFO]: [BentoBox] DEBUG: Global LimitAmount = 16
[08:20:47 INFO]: [BentoBox] DEBUG: Count = 6
[08:20:47 INFO]: [BentoBox] DEBUG: Checking group limits
[08:20:47 INFO]: [BentoBox] DEBUG: Island LimitAmount = -1
[08:20:47 INFO]: [BentoBox] DEBUG: Global LimitAmount = 16
[08:20:47 INFO]: [BentoBox] DEBUG: Count = 5
[08:20:47 INFO]: [BentoBox] DEBUG: Checking group limits
[08:20:47 INFO]: [BentoBox] DEBUG: Island LimitAmount = -1
[08:20:47 INFO]: [BentoBox] DEBUG: Global LimitAmount = 16
[08:20:47 INFO]: [BentoBox] DEBUG: Count = 6
[08:20:47 INFO]: [BentoBox] DEBUG: Checking group limits
[08:20:47 INFO]: [BentoBox] DEBUG: Island LimitAmount = -1
[08:20:47 INFO]: [BentoBox] DEBUG: Global LimitAmount = 16
[08:20:47 INFO]: [BentoBox] DEBUG: Count = 20
[08:20:56 INFO]: [BentoBox] DEBUG: Island LimitAmount = -1
[08:20:56 INFO]: [BentoBox] DEBUG: Global LimitAmount = 16
[08:20:56 INFO]: [BentoBox] DEBUG: Count = 7
[08:20:56 INFO]: [BentoBox] DEBUG: Checking group limits

Plugin 2:

[08:29:33] [Server thread/INFO]: [BentoBox] DEBUG: Island LimitAmount = -1
[08:29:33] [Server thread/INFO]: [BentoBox] DEBUG: Global LimitAmount = 16
[08:29:33] [Server thread/INFO]: [BentoBox] DEBUG: Count = 20
[08:29:34] [Server thread/INFO]: [BentoBox] DEBUG: Island LimitAmount = -1
[08:29:34] [Server thread/INFO]: [BentoBox] DEBUG: Global LimitAmount = 16
[08:29:34] [Server thread/INFO]: [BentoBox] DEBUG: Count = 20
[08:29:34] [Server thread/INFO]: [BentoBox] DEBUG: Island LimitAmount = -1
[08:29:34] [Server thread/INFO]: [BentoBox] DEBUG: Global LimitAmount = 16
[08:29:34] [Server thread/INFO]: [BentoBox] DEBUG: Count = 20
[08:29:34] [Server thread/INFO]: [BentoBox] DEBUG: Island LimitAmount = -1
[08:29:34] [Server thread/INFO]: [BentoBox] DEBUG: Global LimitAmount = 16
[08:29:34] [Server thread/INFO]: [BentoBox] DEBUG: Count = 20
[08:29:34] [Server thread/INFO]: [BentoBox] DEBUG: Island LimitAmount = -1
[08:29:34] [Server thread/INFO]: [BentoBox] DEBUG: Global LimitAmount = 16
[08:29:34] [Server thread/INFO]: [BentoBox] DEBUG: Count = 20
[08:29:34] [Server thread/INFO]: [BentoBox] DEBUG: Island LimitAmount = -1
[08:29:34] [Server thread/INFO]: [BentoBox] DEBUG: Global LimitAmount = 16
[08:29:34] [Server thread/INFO]: [BentoBox] DEBUG: Count = 20
[08:29:38] [Server thread/INFO]: [BentoBox] DEBUG: Island LimitAmount = -1
[08:29:38] [Server thread/INFO]: [BentoBox] DEBUG: Global LimitAmount = 16
[08:29:38] [Server thread/INFO]: [BentoBox] DEBUG: Count = 5
[08:29:38] [Server thread/INFO]: [BentoBox] DEBUG: Checking group limits
[08:29:38] [Server thread/INFO]: [BentoBox] DEBUG: Island LimitAmount = -1
[08:29:38] [Server thread/INFO]: [BentoBox] DEBUG: Global LimitAmount = 16
[08:29:38] [Server thread/INFO]: [BentoBox] DEBUG: Count = 4
[08:29:38] [Server thread/INFO]: [BentoBox] DEBUG: Checking group limits

Fyi: the real number of cows on this island is 8/16. Is it possible that Limits confuses mushroom_cows with (normal) cows?

tastybento commented 4 years ago

Yes! That is it! Mushroom cow is a subclass of cow, so when cows are requested, it gets them too. I will fix this now.

tastybento commented 4 years ago

Please try the latest build.

x1p commented 4 years ago

Works like a charm again 👍

BentoBoxWorld / Limits

Prevented breeding way under limit #105