Bug when spawning IronGolem using Jack 'o lantern

[ChimpGamer]

Description

Describe the bug

When BentoBox is installed it doesn't remove all iron blocks and the Jack 'o lantern when building an Iron Golem. Without BentoBox this works just fine.

Steps to reproduce the behavior

Build an iron golem using a Jack 'o lantern

Expected behavior

The vanilla behaviour

Screenshots and videos (Optional)

https://www.youtube.com/watch?v=YzgzkNNAu9A

Environment

Output of /bbox version (Mandatory)

Running PAPER 1.16.5.
BentoBox version: 1.16.1
Database: JSON
Loaded Game Worlds:
skyblock_world (SkyBlock): Overworld, Nether, [end_color]End
Loaded Addons:
AutoIslandFly 1.0.0 (ENABLED)
Bank 1.3.0 (ENABLED)
Biomes 1.13.0 (ENABLED)
BSkyBlock 1.14.3 (ENABLED)
Challenges 0.8.3 (ENABLED)
Chat 1.1.2 (ENABLED)
ControlPanel 1.7.0 (ENABLED)
DimensionalTrees 1.6.0 (ENABLED)
EpicHooks 1.0.0 (ENABLED)
ExtraMobs 1.11.0.4-SNAPSHOT-b7 (ENABLED)
IslandFly 1.8.0 (ENABLED)
Level 2.6.0 (ENABLED)
Likes 1.7.0 (ENABLED)
Limits 1.15.0 (ENABLED)
MagicCobblestoneGenerator 2.3.0 (ENABLED)

Plugins (Optional)

_______

Additional context (Optional)

[tastybento]

Try the latest version of Limits.

[ChimpGamer]

Same issue with the latest version.

Edit: I accidently closed the issue.

[tastybento]

I cannot replicate this issue. What settings do you have for Limits? Please share the config. Also, what permissions does your player have that is doing this? If Limits is not installed, does this issue occur?

[HamtaBot]

try to limit iron golems

[HamtaBot]

the bug disapear when we remove limits addon @tastybento

[tastybento]

I tried to limit but I still cannot replicate. Please share your Limits config.yml. I might need to give you a debug version to find out why the blocks cannot be set to air.

What plugins are you running? Any anti-cheat ones?

[HamtaBot]

[00:10:46 INFO]: Plugins (59): AnimatedScoreboard, AntiAutoClick, AureliumSkills, BattlePass, BeautyQuests, BentoBox, BetterSleeping3, BungeeGuard, Citizens, CommandHook, DeluxeChat, DeluxeMenus, DyedBackpacks, Essentials, EssentialsSpawn, ExoticGarden, ExtraTools, FastChunkPregenerator, FluffyMachines, GeinsBasics, GoldenCrates, HolographicDisplays, HolographicExtension, InfinityExpansion, Jobs, JukeBox, LiteXpansion, LuckPerms, Maintenance, MessageAnnouncer, MineableSpawners, MMOItems, Multiverse-Core, MythicLib, MythicMobs, NexEngine, NoteBlockAPI, OldCombatMechanics, PlaceholderAPI, Playtimes, ProtocolLib, Rankup, SFCalc, Shop, ShopGUIPlus, Shopkeepers, Slimefun, spark, TAB, TradeSystem, Vault, VoidGenerator, WildStacker, WitherSound, WorldEdit, WorldGuard, WorldGuardExtraFlags, XPBoost, zAuctionHouseV3 container:~/$

config

# Game Modes covered by limits
gamemodes:
- AcidIsland
- BSkyBlock
- CaveBlock

# Permissions
# Island owners can be given permissions that override all general settings
# Format is GAME-MODE-NAME.island.limit.MATERIAL.LIMIT
# example: bskyblock.island.limit.hopper.10
# permission activates when player logs in.
#
# Cooldown for player recount command in seconds
cooldown: 120

# General block limiting
# Use this section to limit how many blocks can be added to an island.
# 0 means the item will be blocked from placement completely.
# These limits apply to every game mode world
blocklimits:
  HOPPER: 1000
  PLAYER_HEAD: 3500
# This section is for world-specific limits and overrides the general limit
# Specify each world you want to limit individually (including nether and end worlds)
# If these worlds are not covered by the game modes above, nothing will happen
worlds:
  AcidIsland_world:
    HOPPER: 11

# Default entity limits within a player's island space (protected area and to island limit).
# A limit of 5 will allow up to 5 entities in over world, 5 in nether and 5 in the end.
# Affects all types of creature spawning. Also includes entities like MINECARTS.
# Note: Only the first 49 limited blocks and entities are shown in the limits GUI.
entitylimits:
   WITHER_SKELETON: 0
   BEE: 10
   WITHER: 10
   ENDERMAN: 10
   CHICKEN: 10
   PIGLIN: 30
   COW: 17
   SHEEP: 17
   RABBIT: 17
   SQUID: 3
   BAT: 1
   PHANTOM: 3
   CAT: 5
   ZOMBIE: 10
   CAVE_SPIDER: 10
   COD: 3
   BLAZE: 35
   CREEPER: 10
   DOLPHIN: 3
   DONKEY: 10
   HORSE: 10
   PIG: 17
   PARROT: 10
   DROWNED: 10
   ELDER_GUARDIAN: 40
   GUARDIAN: 40
   WITCH: 10
   ENDERMITE: 10
   EVOKER: 5
   FOX: 10
   GHAST: 10
   HUSK: 10
   LLAMA: 10
   MAGMA_CUBE: 20
   SLIME: 10
   MULE: 10
   OCELOT: 10
   PANDA: 10
   POLAR_BEAR: 10
   RAVAGER: 5
   VILLAGER: 10
   IRON_GOLEM: 17
   SALMON: 3
   SHULKER: 10
   SKELETON: 10
   SKELETON_HORSE: 10
   SPIDER: 10
   STRAY: 10
   VEX: 5
   TURTLE: 10
   WOLF: 12
   ZOMBIE_VILLAGER: 10
   VINDICATOR: 10
   PUFFERFISH: 3
   TROPICAL_FISH: 3

[ChimpGamer]

Without the Limits addon it works just fine.

[tastybento]

I can't replicate it, so I assume it's another plugin interrupting the substitution for some reason. Anyway, I added an option to turn off async gloom checking. Add this to your config.yml with the latest build off the CI and see if that solves the issue:

# Use async checks for snowmen and iron golums. Set to false if you see problems.
async-golums: false

See https://github.com/BentoBoxWorld/Limits/blob/6a2768e572dbb4be66ee61bd1ef473357f0aa361/src/main/resources/config.yml#L16

[ChimpGamer]

I updated and added that to my config but now the golem doesn't spawn when using a Jack `o lantern.