[limits] Config.yml option to prevent limits bypass with breeding

mrfloris commented 1 year ago

Is your feature request related to a problem?

Yes, players can bypass limits by breeding mobs.

Describe the solution you'd like.

A config.yml setting that is false by default, so it doesn't change existing servers, but server owners who want to prevent breeding bypass to be able to set this to true.

Describe alternatives you've considered.

n/a

Agreements

[X] I have searched for and ensured there isn't already an open issue regarding this.
[X] I have ensured the feature I'm requesting isn't already in the latest supported BentoBox build or Addons.

Other

Tested this as operator, staff and as player. We noticed players figured out they could breed to bypass limits. Can't find permissions or config.yml setting for it, so I don't assume this is a bug but maybe an oversight or just technically not possible? So requesting it as a feature, thank you for considering.

> bbox version
[01:57:26 INFO]: Running PAPER 1.19.3.
[01:57:26 INFO]: BentoBox version: 1.22.1-SNAPSHOT-b2367
[01:57:26 INFO]: Database: JSON
[01:57:26 INFO]: Loaded Game Worlds:
[01:57:26 INFO]: acid (acid): Overworld
[01:57:26 INFO]: cave (cave): Overworld
[01:57:26 INFO]: oneblock (oneblock): Overworld
[01:57:26 INFO]: skyblock (skyblock): Overworld
[01:57:26 INFO]: skygrid (skygrid): Overworld
[01:57:26 INFO]: Loaded Addons:
[01:57:26 INFO]: AcidIsland 1.17.2-SNAPSHOT-b981 (ENABLED)
[01:57:26 INFO]: AOneBlock 1.12.4-SNAPSHOT-b309 (ENABLED)
[01:57:26 INFO]: Biomes 2.2.0-SNAPSHOT-b245 (ENABLED)
[01:57:26 INFO]: Border 4.1.0 (ENABLED)
[01:57:26 INFO]: BSkyBlock 1.17.0-SNAPSHOT-b730 (ENABLED)
[01:57:26 INFO]: CauldronWitchery 2.1.0-SNAPSHOT-#45 (ENABLED)
[01:57:26 INFO]: CaveBlock 1.18.0-SNAPSHOT-b433 (ENABLED)
[01:57:26 INFO]: Challenges 1.2.0-SNAPSHOT-b510 (ENABLED)
[01:57:26 INFO]: ExtraMobs 1.12 (ENABLED)
[01:57:26 INFO]: FarmersDance 1.0.0-SNAPSHOT (ENABLED)
[01:57:26 INFO]: Greenhouses 1.7.3-SNAPSHOT-b344 (ENABLED)
[01:57:26 INFO]: Level 2.10.0-SNAPSHOT-b528 (ENABLED)
[01:57:26 INFO]: Limits 1.19.1-SNAPSHOT-b305 (ENABLED)
[01:57:26 INFO]: MagicCobblestoneGenerator 2.5.0 (ENABLED)
[01:57:26 INFO]: SkyGrid 1.19.0-SNAPSHOT-b402 (ENABLED)
[01:57:26 INFO]: TopBlock 0.0.1-SNAPSHOT-b11 (ENABLED)
[01:57:26 INFO]: Warps 1.13.0-SNAPSHOT-b340 (ENABLED)
> ver
[01:57:33 INFO]: This server is running Paper version git-Paper-448 (MC: 1.19.3) (Implementing API version 1.19.3-R0.1-SNAPSHOT) (Git: 155aa36)
You are running the latest version
Previous version: git-Paper-446 (MC: 1.19.3)
>

tastybento commented 1 year ago

Players definitely should not be able to breed to bypass limits. Ops can, and mods with the [gamemode].mod.bypass perm can. So, if this is happening then it is a bug. I'll have to test to confirm, but the very purpose of Limits is to prevent over breeding...

mrfloris commented 1 year ago

That's what I assumed, but we started to notice.. i just checked for the perm, they return false and don't have it wildcarded.

tastybento commented 1 year ago

All seems to work. I've got the default 10 chicken limit and made sure I wasn't Op and then gave them seeds. They showed hearts but when they tried to mate, nothing happened and the error was shown.

mrfloris commented 1 year ago

Thank you for confirming, then we know it's on my end, will review perms and check against docs if I use the right one etc.

mrfloris commented 1 year ago

@tastybento uuhm, i checks docs.bbox and can't find mod.bypass at all, I see mentions of gametype mod.bypass[TYPE], but none are related to breeding to limits ? and the limits page doesn't have the word bypass in the perms at all.

Can you perhaps link me?

tastybento commented 1 year ago

It was missing in the docs. I updated them: https://docs.bentobox.world/en/latest/addons/Limits/#permissions

BentoBoxWorld / Limits