BentoBoxWorld / Limits

Limits blocks and entities on islands - for BentoBox
Eclipse Public License 2.0
8 stars 17 forks source link

Per World limiting #58

Closed x1p closed 4 years ago

x1p commented 4 years ago

Description Limiting blocks (blocklimits) per world counts as if all worlds count. Example:

blocklimits:
  HOPPER: 500
worlds:
  bskyblock_world_nether:
    HOPPER: 50

If the overworld has >50 hoppers, no hopper is allowed to be placed in the nether. My own logic would count as follows: 450 hoppers in the overworld and 50 in the nether. or 500 hoppers in the overworld of course.

Steps to reproduce the behavior:

  1. Set limits as above
  2. Place 45 hoppers in the overworld
  3. Go to the nether and place as many as you can
  4. See that only 5 hoppers are possible, despite the limit of 50.

Expected behavior Limiting things per world would imho not include numbers in the global limit if per world is more strict than global

Screenshots

Server Information:

[Please complete the following information:]

Additional context

tastybento commented 4 years ago

The calculations are like this because currently the nether and end are all summed with the over world. I.e., the “world” for a game mode = overworld + nether + end. The config for other worlds is for game mode worlds like AcidIsland or Caveblock.

Is there some need to really limit a player by environment/dimension? If so then this is an enhancement that can be considered.

x1p commented 4 years ago

Hmm strange logic but ok. Thanks though. I will discuss internally what to do with this.