search

BentoBoxWorld / Limits

Limits blocks and entities on islands - for BentoBox
Eclipse Public License 2.0
8 stars 17 forks source link

Infinite parrot duplication #97

Closed Espantonius closed 3 years ago

Espantonius commented 3 years ago

Description When you have tame parrots and they are put on your shoulder, you can duplicate the parrots infinite times by shifting.

Screenshots Here a small gif: https://gyazo.com/70c89d47bad4cf4041c54e57336695f8

Server Information: Running PAPER 1.16.2. BentoBox version: 1.15.1-SNAPSHOT-b1867 Database: JSON Loaded Game Worlds: skyblock (SkyBlock): Overworld, Nether, The End Loaded Addons: BSkyBlock 1.14.1-SNAPSHOT-b670 (ENABLED) Limits 1.15.0-SNAPSHOT-b230 (ENABLED)

Espantonius commented 3 years ago

I just checked that it also happens with the mob generators. You can spawn infinities. Here you can see: https://gyazo.com/6c8d3a4a2e212f51e73417ff1fa9e554

tastybento commented 3 years ago

Thanks. I'll check into that.

tastybento commented 3 years ago

Ugh. This is big job. Please use the release version because it looks like the snapshot approach will need a lot of reworking to handle all the spawn events.

tastybento commented 3 years ago

Okay, I think I found a way to avoid this without a massive rewrite. Please try the latest snapshot build and check if there are any exploits.

Espantonius commented 3 years ago

Perfect. The one with the parrots and the generators are fixed. I just found another problem with the wither. When creating it horizontally, the blocks remain. Here you can see: https://gyazo.com/dbbd3659e6913bdbfb63400674c89f29

tastybento commented 3 years ago

I didn't know that could be done. I've always done it vertically. This is fixable.

tastybento commented 3 years ago

Should be fixed now.

Espantonius commented 3 years ago

Perfect. I just tried and everything is solved. Thanks!

PatoTheBest commented 3 years ago

@tastybento Hey!

This wasn't patched completely. Wither bosses can also be spawned with soul soil (new block form 1.16). I don't blame you as I wasn't aware of this either haha.

https://i.imgur.com/vlYhoh6.mp4

The code would just need to change to check if the block placed is a witherSpawnable block (so right now either soul sand or soul soil)

Thanks!