search

benzammour / cretro

👾 cretro - Yet another Chip 8 Emulator!
MIT License
4 stars 2 forks source link

feat: adding ability to handle command line arguments #12

Closed mormod closed 1 year ago

mormod commented 1 year ago

This PR adds the ability to handle command line flags, which can be useful to customize behavior later on. This could be used for #3, to enable debugger capabilities by using a flag.

mormod commented 1 year ago

If there are no more corrections necessary (@marcluque, @Benzammour), this could be merged.

marcluque commented 1 year ago

If there are no more corrections necessary (@marcluque, @Benzammour), this could be merged.

I made some more review suggestions, but apart from that LGTM.

benzammour commented 1 year ago

Isn't this PR a subset of #10 with minor differences?

mormod commented 1 year ago

Isn't this PR a subset of #10 with minor differences?

At this point, yes. You can close this pull request @Benzammour. I'll merge the necessary changes from this PR to #10.

mormod commented 1 year ago

Closing this, this has been handled in #10.