Open ds5678 opened 3 months ago
After doing some more validation, I discovered that the Cecil HasOverrides
property was always returning false. In light of that, I have removed the HasOverrides check entirely. The output is now almost exactly consistent.
The validator is available here: https://github.com/AssetRipper/AssetRipper.CIL/tree/ecdd481b87f5f4872897d7408eae6eedaab5834e/AssetRipper.CIL.Validator
@SamboyCoding Thank you for the review! I'll address these tonight.
Thanks again for the review. I made some changes based on your feedback.
Note: my latest commit "broke" consistency due to changing the corlib, which caused a ton of imported references to become inequal, but otherwise it's still consistent.
I have verified this to be consistent with the prior Cecil implementation, with a few exceptions:
The AsmResolver-basedHasOverrides
is more accurate than the Cecil one, which causes some additional virtual methods and properties to be culled.This has some minor side effects like slightly changing the content of static constructors in the declaring types of the newly culled methods.Assembly-CSharp.dll
, there are only 45 differing methods, out of 104,874 total methods.