Closed MichielStock closed 3 years ago
Agreed with Daan
Op zo 19 sep. 2021 17:30 schreef DaanVanHauwermeiren < @.***>:
@.**** requested changes on this pull request.
In notebooks/day1/01-basics-extra.jl https://github.com/Beramos/DS-Julia2925/pull/109#discussion_r711762016:
@@ -5,7 +5,7 @@ using Markdown
using InteractiveUtils
╔═╡ 4109a39c-00b7-4954-bb73-35407f82a6f7
-using Pkg; Pkg.add(url="https://github.com/Beramos/DS-Julia2925")
+using Pkg; Pkg.activate("../..")
why is the DSJulia package environment activated here? I thought we were going to keep these separated? i.e. the env in the DSJulia only for the things in DSJulia and the env in notebooks for everything else you need in the course
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Beramos/DS-Julia2925/pull/109#pullrequestreview-758161228, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACYUUXEECVMPBKHS5OTEGF3UCX6ZVANCNFSM5EKIVVSQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
note: for metaprogramming in day2 I have added a project.toml file in notebooks/day2. I thought that was the easiest solution
Went through all the notebooks, minor changes:
Pkg; Pkg.install("DS-Julia")
toPkg; Pkg.activate("../..")
in the notebooks, using the local environment of our repoHope these work without trouble now!