search

BereketRetta / JS_Capstone_Project

1 stars 0 forks source link

[0.4pt] Find External API, for the project. #1

Open BereketRetta opened 2 years ago

BereketRetta commented 2 years ago

Find an API to base the development of the web app around it. The API should allow you to

--- Get a list of items with a unique item id (or generate the unique id). --- Choose an API that doesn't need authentication. if you select an API that requires authentication, you should implement it on your own. Also, if you select an API that provides image resources your web app will be more visual. --- There are two people in this project. Ismail Akinkunmi Bereket Retta Project link: https://github.com/BereketRetta/JS_Capstone_Project/projects/1

EricMbouwe commented 2 years ago

Hi @team,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request ❌

You have submitted a project, that is missing in your issue

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

TedLivist commented 2 years ago

STATUS: INVALID CODE REVIEW REQUEST 🛑 🛑

Hi @ismailakinkunmi AND @BereketRetta,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted an Issue that does not have an accurate link to your Kanban board project. You submitted your repository link whereas you are expected to submit your Kanban project link; I think this is the link you are looking for: https://github.com/BereketRetta/JS_Capstone_Project/projects/1

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

ismailakinkunmi commented 2 years ago

@TedLivist thanks

medaminedev66 commented 2 years ago

Required Changes ♻️

Hi @ismailakinkunmi and @BereketRetta ,

Good job so far! You still need to work on some issues to go to the next project, but you are almost there!

Aspects to improve ♻️

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.

micheaol commented 2 years ago

Hi @TedLivist and @BereketRetta ,

Great work on making the changes requested by the previous reviewer 👏 You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.

Required Changes ♻️

Your Kanban board doesn't have the project's tasks as required. Please check this LINK to see how many cards you should have on your Kanban board for a team of 2(two) members. This link will help you to set up properly. Please follow the steps described in curriculum-tools-copy-projects to know how to copy the template board to your Kanban board.

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

_As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

mateo951 commented 2 years ago

Hi Team,

I'm marking the following comments as optional because it was not required by your other reviewers. You are not obligated to do them but I highly recommend it 😉

OPTIONAL

image

Well done making all the necessary changes requested by your previous reviewers! Your project is complete! There is nothing else to say other than... it's time to merge it 🔥

Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

BereketRetta commented 2 years ago

Thank you @mateo951