ismailakinkunmi
commented
2 years ago The comment button popup is not part of my task, kindly check the project task in the kanban board also, I drop a note in the PR, and the REpo is not mine the [image: Screenshot (106).png]
On Sat, Feb 12, 2022 at 10:26 PM Moise Rushanika @.***> wrote:
@.** requested changes on this pull request. Hi **@.** https://github.com/ahmetbozaci,
You did a great job so far 👏🏼 👏🏼 There are some issues that you still need to work on to go to the next project but you are almost there! To highlight 💪🏻
- No linter errors. ✔️
- Gitflow was correctly used. ✔️
- Good commit messages ✔️
- You have followed JavaScript best practices. ✔️ 👍 Good job!
STATUS: CHANGES REQUESTED ♻️
Please Check the comments under the review and make all required changes Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏 💻 Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please ping me @moise10r https://github.com/moise10r when you comment so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
In README.md https://github.com/BereketRetta/JS_Capstone_Project/pull/26#discussion_r805204581 :
-install all the packages needed by this command :
+install all the packages needed with the command below :
I believe you have put a lot of work into this project 💪 However your readme or PR doesn't contain a video of you explaining your project. It is a requirement to do a video presentation of your project to give visitors some insight into your project. You can summarize your video using the following bullet points.
- Recorded a video presenting the features of the project.
- The maximum length of the video is 5 minutes.
- The video contains a clear and objective description of the project in professional English. The topic and purpose of the project are made clear.
- The video contains a demo of the project, highlighting all the project features.
- The video contains a highlight about a piece of the code the student finds interesting or is proud of making.
In dist/main.js https://github.com/BereketRetta/JS_Capstone_Project/pull/26#discussion_r805205935 :
@@ -126,7 +126,7 @@ eval("webpack_require.r(webpack_exports);\n/ harmony import / var _sty
****/
/***/ ((unused_webpack_module, webpack_exports, webpack_require__) => {
-eval("webpack_require.r(webpack_exports);\n/ harmony export / webpack_require.d(webpack_exports, {\n/ harmony export / \"default\": () => (WEBPACK_DEFAULT_EXPORT)\n/ harmony export / });\nconst getMovies = async () => {\r\n const moviesData = await fetch(\"https://api.tvmaze.com/shows?page=2\");\r\n const allData = await moviesData.json();\r\n\r\n const data = allData.slice(0, 10).map((item) => item);\r\n return data;\r\n};\r\n\r\n/ harmony default export / const WEBPACK_DEFAULT_EXPORT = (getMovies);\r\n\n\n//# sourceURL=webpack://capstone_project_2/./src/modules/apiCall.js?");
+eval("webpack_require.r(webpack_exports);\n/ harmony export / webpack_require.d(webpack_exports, {\n/ harmony export / \"default\": () => (WEBPACK_DEFAULT_EXPORT)\n/ harmony export / });\nconst getMovies = async () => {\r\n const moviesData = await fetch(\"https://api.tvmaze.com/shows?page=2\");\r\n const allData = await moviesData.json();\r\n\r\n const data = allData.slice(0, 20).map((item) => item);\r\n return data;\r\n};\r\n\r\n/ harmony default export / const WEBPACK_DEFAULT_EXPORT = (getMovies);\r\n\n\n//# sourceURL=webpack://capstone_project_2/./src/modules/apiCall.js?");
- There is an issue with your comment button, as required When a user clicks on the "Comments" button, the Comments popup appears. and the web app is expected to retrieve data from the selected API and show details about the selected item. And likewise, retrieve data from the Involvement API https://www.notion.so/Involvement-API-869e60b5ad104603aa6db59e08150270 to show the item comments. But it does not work as expected
— Reply to this email directly, view it on GitHub https://github.com/BereketRetta/JS_Capstone_Project/pull/26#pullrequestreview-880891103, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI5YZRVENSCFK55OQWSFRJTU23GBHANCNFSM5OHOWP5A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>
noted We started this project as two coding partners but due to personal responsibilities my partner could not continue so Anne-Lore De Vreese (Program Coach) said I should do my part and noted it in the PR also, Due to an access level I couldn't set Github pages for this project.