BergmannLab / MONET

MONET : MOdularising NEtwork Toolbox - https://doi.org/10.1093/bioinformatics/btaa236
GNU General Public License v3.0
42 stars 15 forks source link

set numerical separator in result-modules output file to 1.0 #32

Closed mattiat closed 4 years ago

mattiat commented 4 years ago

See section OUTPUT of README file: "the second value is an arbitrary numerical value and should be ignored".

I think we should keep it, to avoid changes in the scoring pipeline, but it would be nice to set it to the same value, say: "0.0"

sergio-gomez commented 4 years ago

According to the challenge, that value was added to have the possibility of assigning our level of confidence to each community. Using 0.0 as default does not seem the best idea, it does not respects the semantics (even if all of us have decided to set it to a constant); I would vote for 1.0.

Changing this value for M1 is trivial, so this should not be the problem:

change line 1039 f.write("%d\t1.0\t" % comm_id) of .src/M1_code/sub-challenge1/aleph_urv_method.py to f.write("%d\t0.0\t" % comm_id)

mattiat commented 4 years ago

Uh, I had missed the meaning of that value completely!

@WeijiaZhang24, @sergio-gomez, @jjc2718: Let's vote!

sergio-gomez commented 4 years ago

I've voted for 1.0 :-) I do not really know any simple method to assign confidence scores to the modules, apart from their contribution to global modularity (although they are size-dependent, and also resolution dependent, so I would avoid them).

mattiat commented 4 years ago

Right, then this is already the end of the discussion.

@WeijiaZhang24: could you simply set this value to 1.0 in R1 as well?

TODO: Mattia update README once this is done.

WeijiaZhang24 commented 4 years ago

No problem. I will set the value to 1.0.

Regards Weijia

On Tue, 10 Mar 2020, 01:00 Mattia, notifications@github.com wrote:

Right, then this is already the end of the discussion.

@WeijiaZhang24 https://github.com/WeijiaZhang24: could you simply set this value to 1.0 in R1 as well?

TODO: Mattia update README once this is done.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BergmannLab/MONET/issues/32?email_source=notifications&email_token=AGJTSILE3HDDD4OP2JNNX2TRGT4P3A5CNFSM4LDCORMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHOHUQ#issuecomment-596566994, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGJTSILMNIFTSYUPTCOMWPDRGT4P3ANCNFSM4LDCORMA .

sergio-gomez commented 4 years ago

I would say we only need to substitute line 256 in file R1_code/sub-challenge1/mlrmcl_r4_v2.R from temp<-c(i,0.5,output[[i]]) to temp<-c(i,1.0,output[[i]])

Mattia, try it and, if works, let's close this issue.

WeijiaZhang24 commented 4 years ago

I have submit a commit a few days ago and changed the value to 1.0

sergio-gomez commented 4 years ago

You're right, it seems the merge is pending

mattiat commented 4 years ago

Thank you!