Deploy on Heroku and Testing

[wanze]

Deploy the app on Heroku and create several Test-Accounts. Test the functionalities of the app and if there are still bugs, open them here as issue...

@lexruee Do you think we can deploy this evening or tomorrow morning so that we have enough time for testing? I'm available till 17.00 tomorrow...

[lexruee]

@wanze I will deploy a first version this evening.

[lexruee]

https://radiant-depths-9885.herokuapp.com/

[lexruee]

Some heroku realted bugs are fixed.

[Bergrebell]

there might be a bug with the achievements on the heroku deployment! i can see them in the profile but neither the timeline nor the achievements page

[lexruee]

@Bergrebell Can you retest it?

[lexruee]

zut. still does not work. i hate postgres

[wanze]

I can see them??

[Bergrebell]

so strange! it's still only working on the profile page for me!

[Bergrebell]

[lexruee]

@wanze @Bergrebell The bug is there. I can confirm that!

[wanze]

Yep I can confirm also wtf... can anyone accept my friend requests? :D

[wanze]

Suggestion

UserAchievementsController::index

@user_achievements = current_user.achievements.all #Add .all to the call

[lexruee]

@wanze I'll try that

[lexruee]

@wanze Damn this fluent api! That's the problem and this explains why the method latest_achievements works :-).

[lexruee]

@Bergrebell Can you test it again?

[Bergrebell]

@lexruee awesome! works fine now!

[lexruee]

@Bergrebell @wanze http://guides.rubyonrails.org/getting_started.html#adding-a-route-for-comments

Have a look at the comments. So this is basically just a placeholder (CollectionProxy) for calling functions like all, create etc...

class CommentsController < ApplicationController
  def create
    @article = Article.find(params[:article_id])
    @comment = @article.comments.create(comment_params)
    redirect_to article_path(@article)
  end

  private
    def comment_params
      params.require(:comment).permit(:commenter, :body)
    end
end

[Bergrebell]

@lexruee can you have a look at the friends section on the welcome/index view - it doesn't show me new friends

[lexruee]

@Bergrebell Should be fixed. The @friends variable was not initialized :-).

[Bergrebell]

@lexruee perfect! thanks!

[lexruee]

@wanze @Bergrebell @svetakrasikova I guess now it's stable on heroku?

[Bergrebell]

@lexruee haven't found a bug so far! :)

[lexruee]

@Bergrebell @wanze I have just found this one: https://github.com/Bergrebell/CyberCoach/issues/109

An exception is raised because a user which is invited to a passed sport session cannnot edit the results. Which makes sense, but the exception should be catched ^^.

[lexruee]

Last bug is solved! I really hope that everything works :-).