Bergrebell / CyberCoach

1 stars 1 forks source link

CyberCoach adapter for Subscriptions #20

Closed lexruee closed 9 years ago

lexruee commented 9 years ago

@svetakrasikova Hi Sveta

Sorry, that I could not hold to the deadline. However, I have updated the adapter.

Concerning the rest adapter. Everything is now placed in one single file called: rest_adapter.rb in the lib folder.

If you want to study this mess, I would start to read the user tests beginning with the third test and then the adapter class user.

https://github.com/Bergrebell/CyberCoach/blob/dev/lib/rest_adapter.rb

So the basic things are implemented (but not all things) for the resource partnership, user and sport.

If any other features are needed we can implement them on demand.

What is missing right know is a basic subscription adapter with some simple tests like: get all subscriptions

Cheers, Alex

svetakrasikova commented 9 years ago

@lexruee Hi Alex, I'm starting on this right now. Thanks a lot and no problem, I'll be working on the subscription adapter and anything else that needs to be done here till Tuesday (nothing else interfering).

lexruee commented 9 years ago

@svetakrasikova Please take it easy, we're not in a rush. (That's a lot of code and some ugly hacks...) If there are any questions just ask. I don't expect that somebody can read this mess :-).

Here are some examples (subscription): http://diufvm31.unifr.ch:8090/CyberCoachServer/resources/partnerships/asarteam1;asarteam2/ ` <?xml version="1.0" encoding="UTF-8" standalone="yes" ?>

2

`

http://diufvm31.unifr.ch:8090/CyberCoachServer/resources/partnerships/asarteam1;asarteam2/Soccer/

` <?xml version="1.0" encoding="UTF-8" standalone="yes" ?>

2

`

You can use rails console and put the xml content into a string variable

` xml = '<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>

2 ' ` To get a hash, you can use: ` Hash.from_xml(xml) `
svetakrasikova commented 9 years ago

Hi Alex, Thank you very much. I need one more evening for this. I worked through the adapter this morning. It's not a mess at all, but very well structured/commented. You did an amazing job there, as usualI. Now I think I understand what is going on. I may have some specific questions tomorrow. Sveta

17 Oct 2014, в 11:21, Alexander Rüedlinger notifications@github.com написал(а):

@svetakrasikova Please take it easy, we're not in a rush. (That's a lot of code and some ugly hacks...) If there are any questions just ask. I don't expect that somebody can read this mess :-).

Here are some examples (subscription): http://diufvm31.unifr.ch:8090/CyberCoachServer/resources/partnerships/asarteam1;asarteam2/ xml <?xml version="1.0" encoding="UTF-8" standalone="yes" ?>

2

http://diufvm31.unifr.ch:8090/CyberCoachServer/resources/partnerships/asarteam1;asarteam2/Soccer/

xml <?xml version="1.0" encoding="UTF-8" standalone="yes" ?>

2

You can use rails console and put the xml content into a string variable

xml = '<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>

2 ' To get a hash, you can use: Hash.from_xml(xml) — Reply to this email directly or view it on GitHub.
svetakrasikova commented 9 years ago

@lexruee Alex, should I push what I currently have to the dev branch or create a new branch? To be concrete, I created a class Subscription with the required minimum (create, serialise, initialise), but I haven't written any tests yet. I am going to do it in the next step.

svetakrasikova commented 9 years ago

I pushed to the branch subscr_adapter

lexruee commented 9 years ago

Looks good. I adapted if its okay for you. Subscriptions over users and partnerships are supported. The resource subscription does not really fit well to our resource class. Anyways, I hacked the solution into the subscription.rb file.

You can look at the corresponding tests to get a feeling how its used.

Could you please pull from subscr_adapter and merge it into the dev branch?

svetakrasikova commented 9 years ago

I merged it into dev. Looking at the tests. Thank you, Alex. 21 Oct 2014, в 22:21, Alexander Rüedlinger notifications@github.com написал(а):

Looks good. I adapted if its okay for you. Subscriptions over users and partnerships are supported. The resource subscription does not really fit well to our resource class. Anyways, I hacked the solution into the subscription.rb file.

You can look at the corresponding tests.

Could please pull from subscr_adapter and merge it into the dev branch?

— Reply to this email directly or view it on GitHub.