search

Bergrebell / CyberCoach

1 stars 1 forks source link

Filter does not work correctly #94

Closed wanze closed 9 years ago

wanze commented 9 years ago

On my local installation I have problems with the sport filter:

I'm not sure, I think it's hard to implement a good filter. What do you guys think, should we try it until the deadline or leave it out? I have the feeling that the current state is not a real "feature" for the app.

Cheers

svetakrasikova commented 9 years ago

:( Nobody should try to fix it but me. I'll try to invest a couple of hours into this today and will see what comes out of it.

Îòïðàâëåíî ñ iPhone

7 äåê. 2014 ã., â 2:18, Stefan Wanzenried notifications@github.com íàïèñàë(à):

On my local installation I have problems with the sport filter:

Entering dates does not seem to filter anything If filtering in runnings context, the next request loads the sport session page If selecting a pariticpant, no sessions are displayed at all I'm not sure, I think it's hard to implement a good filter. What do you guys think, should we try it until the deadline or leave it out? I have the feeling that the current state is not a real "feature" for the app.

Cheers

— Reply to this email directly or view it on GitHub.

svetakrasikova commented 9 years ago

@wanze Stefan, I've just noticed the problem and fixed it. The partial for the filter was not parametrised properly and separate sports were handled generically, as sport sessions.It's ok now. I tested a bit and at least the dates filter is working fine. Running (and other sports) are not liked to sport sessions page any longer. I cannot reproduce the problem with participants, but maybe I need to test more. In any case, it's not a big deal if we leave this out, if it looks sloppy and buggy.

svetakrasikova commented 9 years ago

I fixed the problem with filtering by 'participant', and improved the date filter along the following lines: once the 'from' field is filled out its value is copied to the 'to' field automatically, the user can change it if a range is what she wants; if 'to' is smaller than 'from', this is spotted and corrected by setting both fields to the value of the earlier date. It seems to me to be ok the way it is now.

wanze commented 9 years ago

Nice thanks, it works perfect!!!! :)