search

Berikai / bitwig-theme-editor

A theme editor for Bitwig Studio, written educational purpose in mind!
MIT License
80 stars 7 forks source link

Can you add a color format check #6

Open Vondersulzburg opened 2 weeks ago

Vondersulzburg commented 2 weeks ago

I accidantally changed a color from the 8 digit to the 6 digit format and applied this to my Bitwig DAW. After that I not only have to reinstall the DAW I completely have to remove Bitwig deeply from the MAC and reinstall every thing.

So it would be fine if you can add a format comparison to the apply of the mod and if there is a wrong color format just create a prompt with the wrong parameter.

Danke

Berikai commented 2 weeks ago

That shouldn't happen when changing an RGBA value (8 digit) to an RGB value (6 digit). When this happens, the program changes first 6 digit of the value and leave the last one in its space. So, the problem lays somewhere else probably. I've also just tested it and couldn't reproduce it.

By the way, if anything goes wrong, you can just replace the bitwig.jar with the one you back up. So, please do back up your bitwig jar, just in case. A complete reinstall is not needed.

If the issue is reproducable with a specific theme file or in any other way, please let me know!

Vondersulzburg commented 2 weeks ago

Hi Thanks for the fast response. I had a backup and replaced the corrupt one with the original file. Doesn't help. The only thing I changed was this one color with a non transparent color. I use the https://jsonformatter.org/json-editor/ for changing the color. Can you recommend a better one.

I modified your ultra white with more black for the fonts, a nearly white arrange area, and blue for the highlight. I add the file causing the crash

Danke ultra_light_theme.json

Berikai commented 2 weeks ago

image

I couldn't reproduce it with the file you've given. It worked fine for me with Bitwig Studio 5.2 Beta 7.

Most people suggest editing in Visual Studio Code with an extension that shows hex colors in the editor.

Would you mind providing a crash report when launching Bitwig Studio with the version of bitwig theme editor you are using and Bitwig Studio version.

Vondersulzburg commented 2 weeks ago

Interesting I am also on beta 7. Will edit the file tomorrow and then use it with Bitwig.

I will come back after that.

Am 18.06.2024 um 13:48 schrieb Berikai @.***>:

image.png (view on web) https://github.com/Berikai/bitwig-theme-editor/assets/18515671/e539c8a2-5459-40f3-a905-59e30053a2d0 I couldn't reproduce it with the file you've given. It worked fine for me with Bitwig Studio 5.2 Beta 7.

Most people suggest editing in Visual Studio Code with an extension that shows hex colors in the editor.

Would you mind providing a crash report when launching Bitwig Studio with the version of bitwig theme editor you are using and Bitwig Studio version.

— Reply to this email directly, view it on GitHub https://github.com/Berikai/bitwig-theme-editor/issues/6#issuecomment-2175908551, or unsubscribe https://github.com/notifications/unsubscribe-auth/BEJLWU4KSGTYU6VC3E7QULLZIANBHAVCNFSM6AAAAABJPJIIQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZVHEYDQNJVGE. You are receiving this because you authored the thread.

erroreyes commented 2 weeks ago

I tested this under Linux and v5 beta 7 and it loads fine. There are several properties in that JSON file that have 6-bit hex values, and I assume many of them are from the original JSON file before it was modified.