search

BeritJanssen / PatternsForPrediction

Scripts for evaluation and conversion of files in Patterns for Prediction
2 stars 3 forks source link

Incorrect calculation of precision and recall #7

Closed JamesOwers closed 5 years ago

JamesOwers commented 5 years ago

Line 70 in evaluate_prediciton.py results in no value being produced for both precision and recall if there are zero generated notes or the true notes up to a given onset time. However, if there no generated notes we can still get the recall (it's zero). Likewise, if there are no true notes we can still get the precision (it's also zero!).

In relation to issue #6, how nan values are being plotted, this produces artificially high values for small onset values (where there are likely no onsets to observe, and thus missing values).

JamesOwers commented 5 years ago

This would be resolved if #6 is resolved, so closing here.