BerkeleyAutomation / gqcnn

Python module for GQ-CNN training and deployment with ROS integration.
https://berkeleyautomation.github.io/gqcnn
Other
306 stars 149 forks source link

Issue: Bug with analyze_gqcnn_performance #111

Closed anmakon closed 4 years ago

anmakon commented 4 years ago

System information

Describe what you are trying to do

I'm trying to analyse a gqcnn network (trained on dexnet-2.0) on a custom dataset.

Describe current behaviour

When running python tools/analyze_gqcnn_performance GQCNN-2.0 --dataset_config_filename my/config/file, it can't find "log_rate" in the config file.

Fix for the current behaviour

In tools/analyze_gqcnn_performance, line 103 the variable config_filename is overwritten by what should be dataset_config_filename if the --datset_config_filename flag is set. Changing config_filename to dataset_config_filename solves the issue.

visatish commented 4 years ago

Hi @anmakon,

Thanks for pointing this out! I missed it because we normally don't use this flag since we analyze models on the datasets they were trained on. It has been patched in https://github.com/BerkeleyAutomation/gqcnn/pull/113!

Thanks, Vishal