BerkeleyAutomation / malasakit

Malasakit is a customizable participatory assessment platform that collects and integrates quantitative assessment, qualitative feedback, and peer-to-peer collaborative filtering on ways local communities can become better prepared for typhoons and floods.
2 stars 8 forks source link

App crashes when user enters letters in the "Age" text box #47

Closed JustinMi closed 7 years ago

JustinMi commented 7 years ago

image When user submits, the app crashes: image

We need to implement proper error handling.

liboan commented 7 years ago

I think someone (Jonathan?) mentioned Django had form validation #40 or something, sounds like it would be good for this situation

On Tue, May 30, 2017 at 8:05 PM, Justin Mi notifications@github.com wrote:

[image: image] https://cloud.githubusercontent.com/assets/10902110/26610051/0c566a0a-455a-11e7-89e6-c0e15165a466.png When user submits, the app crashes: [image: image] https://cloud.githubusercontent.com/assets/10902110/26610063/168d6ce4-455a-11e7-910f-302e6323388a.png

We need to implement proper error handling.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BerkeleyAutomation/malasakit-v1/issues/47, or mute the thread https://github.com/notifications/unsubscribe-auth/AEDxmbKH3Ga9tuHP15oscLNy-N_RFSM-ks5r_K7JgaJpZM4Nq_58 .

jonathan-j-lee commented 7 years ago

Addressed fully in #56 -- the input element has the attribute type="number", so it is impossible to submit non-numerical characters.