BerkeleyAutomation / malasakit

Malasakit is a customizable participatory assessment platform that collects and integrates quantitative assessment, qualitative feedback, and peer-to-peer collaborative filtering on ways local communities can become better prepared for typhoons and floods.
2 stars 8 forks source link

Model refactor #50

Closed jonathan-j-lee closed 7 years ago

jonathan-j-lee commented 7 years ago
JustinMi commented 7 years ago

also a friendly reminder that after this pull request is merged, we should all git pull origin master and run a migration: python manage.py makemigrations and python manage.py migrate since the models have changed

jonathan-j-lee commented 7 years ago

@JustinMi python manage.py makemigrations essentially looks at the diff between the current database layout (as provided by all the migration files so far) and the layout proposed in models.py, and generates another migration file with some educated guesses for how to restructure the data. python manage.py migrate then applies the operations in this file. However, I manually wrote 0049_model_refactor.py, so there's no need to use makemigrations.

Since this pull request and #48 were developed concurrently, both have migration numbers 49, so whichever is merged later will need to be renumbered to 50.

liboan commented 7 years ago

Didn't notice any issues with data integrity when I looked but worth getting some more eyes on it

sequoiatree commented 7 years ago

I checked too, it gets my badger of approval :3

sequoiatree commented 7 years ago

Woo!