Closed jonathan-j-lee closed 7 years ago
also a friendly reminder that after this pull request is merged, we should all git pull origin master
and run a migration: python manage.py makemigrations
and python manage.py migrate
since the models have changed
@JustinMi python manage.py makemigrations
essentially looks at the diff between the current database layout (as provided by all the migration files so far) and the layout proposed in models.py
, and generates another migration file with some educated guesses for how to restructure the data. python manage.py migrate
then applies the operations in this file. However, I manually wrote 0049_model_refactor.py
, so there's no need to use makemigrations
.
Since this pull request and #48 were developed concurrently, both have migration numbers 49, so whichever is merged later will need to be renumbered to 50.
Didn't notice any issues with data integrity when I looked but worth getting some more eyes on it
I checked too, it gets my badger of approval :3
Woo!
GeneralSetting
model, which contained translations for templates (this will now be handled by Django's built-in translation system, per #45)Progression
modelFlaggedComment
model, which is otherwise identical to theComment
modelComment
now has aflagged
fieldUser
,UserProgression
, andUserData
models into theRespondent
modelUserProgression
can be inferred from the existence of other models (e.g. the existence of at least oneQuantitativeQuestionRating
model implies the user made it to therating
stage)average_score
,number_ratings
in theComment
model)property
decorator__unicode__
for each concrete model to display usable informationmodels.py
models.py
pylint
with thepylint_django
plugin to the build configuration (#36)