search

BerkeleyAutomation / python-fcl

Python binding of FCL library
BSD 3-Clause "New" or "Revised" License
203 stars 58 forks source link

Upgrade to FCL 0.7.0 #51

Closed mjd3 closed 2 years ago

mjd3 commented 2 years ago

Updated for newer versions of FCL and OctoMap; fixes script for Windows so that CI can build from source. Should resolve the remaining issues in #44.

mikedh commented 2 years ago

Nice! I previously got stuck on the windows_ci bit which looked like it depended on prebuilt version locked binaries which made it tough to upgrade. It looks like this makes the build self contained? That was the route I was hoping to go as well, this looks great.

mjd3 commented 2 years ago

Yup should be self-contained now! I think yours was really close already; a lot of this is a mirror of that with some minor changes here and there.

mikedh commented 2 years ago

My only “put” is related to the install_linux: it’s currently checking out your copy of FCL master, once this builds should it lock to a commit or release? I see the upstream fcl is pretty dead (they very infrequently merge PR’s these days) so going off a fork sounds good to me.

mjd3 commented 2 years ago

Yeah good question; the only difference is just one of the PRs from upstream (changing M_PI to be portable) that never got merged. I don't plan on changing anything there, but I will add a tag so that it is consistent in the future just in case.

mjd3 commented 2 years ago

Thanks so much for the quick review @mikedh, updated wheels for 0.6.11 and 0.7.0 are now on pypi!