search

BerkeleyLearnVerify / Scenic

A compiler and scenario generator for the Scenic scenario description language.
https://scenic-lang.org/
Other
274 stars 92 forks source link

I think that there are some typo in the code #189

Open nasy960 opened 1 year ago

nasy960 commented 1 year ago

https://github.com/BerkeleyLearnVerify/Scenic/blob/3af563dd7601b4a04376b91a319a83bac722a957/src/scenic/formats/opendrive/xodr_parser.py#L1443

I think there should be "curve_elem" instead of "cubic_elem".

Is that right?

nasy960 commented 1 year ago

Before I change that, NameError: name 'cubic_elem' is not defined occured. But, after I change that part, it doesn't occured.

Eric-Vin commented 1 year ago

Thanks for the report! This is a definitely a bug and we'll patch it. Unfortunately it wasn't detected by our test suite because we don't have an XODR file with that kind of curve in it. It would be great to add the XODR file you're using to our test suite (assuming that's OK with you and the licensing allows it) to help detect future bugs before they cause you issues.

nasy960 commented 1 year ago

test.zip

This is the file I used for test.

Do I just need to provide the file I use?

Eric-Vin commented 1 year ago

This is great, thanks so much! We'll go ahead and patch this bug.